GH-37065: [C++][Parquet] use std::optional in parquet statistics#49403
Open
Alvaro-Kothe wants to merge 11 commits intoapache:mainfrom
Open
GH-37065: [C++][Parquet] use std::optional in parquet statistics#49403Alvaro-Kothe wants to merge 11 commits intoapache:mainfrom
std::optional in parquet statistics#49403Alvaro-Kothe wants to merge 11 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Most of the CI errors are due to compiler warnings in c_glib due to the deprecations in
cc: @pitrou @felipecrv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Simplify parquet statistics handling by using
std::optionalinstead ofhas_xxxboolean +xxxattribute.What changes are included in this PR?
has_xxxpublic attributes for parquet statistics in favor of usingstd::optionalstd::optionalAre these changes tested?
Partially. The new changes are tested by the existing C++ test-suite. The deprecated methods aren't being tested.
Are there any user-facing changes?
Yes.
This PR includes breaking changes to public APIs.
This PR:
EncodedStatisticsclass;xxx+has_xxx.