GH-50075: [C++][Gandiva] fix buffer overrun in to_hex int32/int64#50076
Open
metsw24-max wants to merge 1 commit into
Open
GH-50075: [C++][Gandiva] fix buffer overrun in to_hex int32/int64#50076metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
|
|
github-actions
Bot
added
Component: C++
Component: Gandiva
awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_hex_int64/to_hex_int32 in string_ops.cc allocate the arena buffer with the bare hex-digit count (16 and 8) but pass that size + 1 to snprintf. A full-width value such as to_hex(-1::bigint) writes 16 digits plus a NUL, one byte past the allocation, corrupting the next arena allocation since gdv_fn_context_arena_malloc returns exactly the requested bytes. Allocate the extra byte, same as the GH-49752 fix in hash_utils.cc.