GH-50535: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test.sh

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2034: test_dir appears unused. Verify it or export it.
• SC1091: Not following: (error message here)
• SC2086: Double quote to prevent globbing and word splitting.

shellcheck ci/scripts/python_test.sh

In ci/scripts/python_test.sh line 23:
test_dir=${1}/python/build/dist
^------^ SC2034 (warning): test_dir appears unused. Verify use (or export if used externally).


In ci/scripts/python_test.sh line 26:
  . "${ARROW_PYTHON_VENV}/bin/activate"
    ^-- SC1091 (info): Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory)


In ci/scripts/python_test.sh line 45:
: ${PYARROW_TEST_ACERO:=${ARROW_ACERO:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 46:
: ${PYARROW_TEST_AZURE:=${ARROW_AZURE:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 47:
: ${PYARROW_TEST_CUDA:=${ARROW_CUDA:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 48:
: ${PYARROW_TEST_DATASET:=${ARROW_DATASET:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 49:
: ${PYARROW_TEST_FLIGHT:=${ARROW_FLIGHT:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 50:
: ${PYARROW_TEST_GANDIVA:=${ARROW_GANDIVA:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 51:
: ${PYARROW_TEST_GCS:=${ARROW_GCS:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 52:
: ${PYARROW_TEST_HDFS:=${ARROW_HDFS:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 53:
: ${PYARROW_TEST_ORC:=${ARROW_ORC:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 54:
: ${PYARROW_TEST_PARQUET:=${ARROW_PARQUET:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 55:
: ${PYARROW_TEST_PARQUET_ENCRYPTION:=${PARQUET_REQUIRE_ENCRYPTION:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 56:
: ${PYARROW_TEST_S3:=${ARROW_S3:-ON}}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/python_test.sh line 72:
pytest -r s ${PYTEST_ARGS} --pyargs pyarrow
            ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
pytest -r s "${PYTEST_ARGS}" --pyargs pyarrow


In ci/scripts/python_test.sh line 76:
  pytest ${PYTEST_RST_ARGS} ${arrow_dir}/docs/source/python
         ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  pytest "${PYTEST_RST_ARGS}" "${arrow_dir}"/docs/source/python

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- test_dir appears unused. Verify u...
  https://www.shellcheck.net/wiki/SC1091 -- Not following: ./bin/activate: op...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

• SC2034: Add a ShellCheck directive to disable the unused variable check.
• SC1091: Add a ShellCheck directive to disable source file checking.
• SC2086: Quote variables.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test.sh #50535

[github-actions]

⚠️ GitHub issue #50535 has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

Rebased on the branch containing the fix for #50538. No changes to this PR since the last commit.

[raulcd]

Thanks for working on those!
I am fine with the workaround we have been taking to avoid ShellCheck SC2086 to preserve space separated options. Thanks for adding comments on those, I think the comments are important as the read -r -a XXXXX <<<< "$YYYY" syntax is slightly less readable.

[hiroyuki-sato]

@raulcd Thank you for your review!

[kou]

+1

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7a59a20.

There was 1 benchmark result indicating a performance regression:

• Commit Run on test-mac-arm at 2026-07-21 02:08:10Z
  • tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-05, scale_factor=1

The full Conbench report has more details. It also includes information about 62 possible false positives for unstable benchmarks that are known to sometimes produce them.