Skip to content

GH-50840: [C++] Fix dead overflow guard in Take on binary-like arrays #50841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanmato1984 merged 1 commit into from
Aug 10, 2026
+26 −3
Merged

GH-50840: [C++] Fix dead overflow guard in Take on binary-like arrays #50841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/src/arrow/compute/kernels/vector_selection_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,9 @@ struct VarBinarySelectionImpl : public Selection<VarBinarySelectionImpl<Type>, T

// Use static property to prune this code from the filter path in
// optimized builds
if (Adapter::is_take &&
ARROW_PREDICT_FALSE(static_cast<int64_t>(offset) +
static_cast<int64_t>(val_size)) > kOffsetLimit) {
if (Adapter::is_take && ARROW_PREDICT_FALSE(static_cast<int64_t>(offset) +
static_cast<int64_t>(val_size) >
kOffsetLimit)) {
return Status::Invalid("Take operation overflowed binary array capacity");
}
offset += val_size;
Expand Down
23 changes: 23 additions & 0 deletions cpp/src/arrow/compute/kernels/vector_selection_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1706,6 +1706,29 @@ TEST_F(TestTakeKernelFSB, TakeFixedSizeBinary) {
TakeCAC(type, {kABNullDE, kABC}, "[4, 10]").Value(&chunked_arr));
}

// GH-50840: taking more data than a 32-bit offset can address must raise
// instead of silently overflowing the offsets buffer.
TEST_F(TestTakeKernel, LARGE_MEMORY_TEST(TakeBinaryOffsetOverflow)) {
// 2048 * 1 MiB = 2 GiB of output, one value past the int32 offset limit.
constexpr int64_t kValueSize = 1 << 20;
constexpr int64_t kNumIndices = 2048;

StringBuilder values_builder;
ASSERT_OK(values_builder.Append(std::string(kValueSize, 'x')));
ASSERT_OK_AND_ASSIGN(auto values, values_builder.Finish());

Int32Builder indices_builder;
ASSERT_OK(indices_builder.Reserve(kNumIndices));
for (int64_t i = 0; i < kNumIndices; ++i) {
indices_builder.UnsafeAppend(0);
}
ASSERT_OK_AND_ASSIGN(auto indices, indices_builder.Finish());

EXPECT_RAISES_WITH_MESSAGE_THAT(
Invalid, ::testing::HasSubstr("Take operation overflowed binary array capacity"),
TakeAAA(*values, *indices));
}

using ListAndListViewArrowTypes =
::testing::Types<ListType, LargeListType, ListViewType, LargeListViewType>;

Expand Down
Loading