GH-50849: [Python] Return correct ParquetLogicalType.type for geometry/geography - #50850
Open
jorisvandenbossche wants to merge 2 commits into
Open
GH-50849: [Python] Return correct ParquetLogicalType.type for geometry/geography#50850jorisvandenbossche wants to merge 2 commits into
jorisvandenbossche wants to merge 2 commits into
Conversation
…eometry/geography
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Python Parquet metadata binding so ParquetLogicalType.type returns the correct string for the GEOMETRY/GEOGRAPHY logical types, matching the underlying Parquet logical type enum.
Changes:
- Extend the logical type enum-to-name mapping to include GEOMETRY and GEOGRAPHY.
- Add a regression test that reads geospatial Parquet fixtures and asserts the logical type name and geo statistics accessors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/pyarrow/_parquet.pyx | Adds GEOMETRY/GEOGRAPHY to the enum name mapping used by ParquetLogicalType.type. |
| python/pyarrow/tests/parquet/test_metadata.py | Adds regression coverage for geometry/geography logical types and geo statistics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix the return value of
ParquetLogicalType.typefor geometry/geography typesAre these changes tested?
Yes
Are there any user-facing changes?
Not apart from the bug fix