ARTEMIS-5376 Preventing OME from QueueImpl::iteration while paging#6251
Draft
clebertsuconic wants to merge 1 commit intoapache:mainfrom
Draft
ARTEMIS-5376 Preventing OME from QueueImpl::iteration while paging#6251clebertsuconic wants to merge 1 commit intoapache:mainfrom
clebertsuconic wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@AntonRoskvist / @jbertram if you guys could review this please? |
clebertsuconic
force-pushed
the
ARTEMIS-5376
branch
from
1986e4b to
8c78763
Compare
Contributor
Author
|
I'm converting this to draft as I have a few test failures |
clebertsuconic
force-pushed
the
ARTEMIS-5376
branch
3 times, most recently
from
8340a2c to
4deeced
Compare
clebertsuconic
force-pushed
the
ARTEMIS-5376
branch
3 times, most recently
from
f0c4d57 to
c755f2e
Compare
Contributor
|
Why do some operations pass |
Contributor
Author
|
changeMessagePriority will need to change the message in memory. That means that the message needs to be in the queue for that to happen. I will convert this to draft BTW as I have a few test failures. |
Contributor
Author
|
@jbertram I will have to remove this allowDepaging thing probably. and keep the old behaviour, however i will have to limit memory accordingly to configuration. |
clebertsuconic
force-pushed
the
ARTEMIS-5376
branch
2 times, most recently
from
f096657 to
cf8b124
Compare
Contributor
Author
|
@jbertram Renamed to separatePageIterator, used only when removing messages with or without a filter. This avoids depaging into memory while maintaining consistency for other operations. |
clebertsuconic
force-pushed
the
ARTEMIS-5376
branch
from
cf8b124 to
b7e2d3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.