AVRO-4264: [C++] Bump vendored fmt to 12.1.0#3799
Open
wgtmac wants to merge 1 commit into
Open
Conversation
Member
Author
martin-g
reviewed
May 25, 2026
| fmt | ||
| GIT_REPOSITORY https://github.com/fmtlib/fmt.git | ||
| GIT_TAG 10.2.1 | ||
| GIT_TAG 12.1.0 |
Member
There was a problem hiding this comment.
The CI checks pass but
- https://github.com/fmtlib/fmt/blob/12.1.0/CMakeLists.txt#L50
- https://github.com/fmtlib/fmt/blob/12.1.0/CMakeLists.txt#L71-L72
say that it needs C++20.
I guess the build will break with an older C++ compiler (that does not support 20).
Member
There was a problem hiding this comment.
me too!
Just split it in two PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation