Skip to content

Remove relative change threshold condition #37643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liferoad wants to merge 2 commits into
base: master
Choose a base branch
from
+0 −6
Open

Remove relative change threshold condition #37643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1acdb40
Remove relative change threshold condition for identifying valid chan…
liferoad Feb 18, 2026
45ad740
Remove unused epsilon variable from `_find_valid_change_points`.
liferoad Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions sdks/python/apache_beam/testing/analyzers/perf_analysis_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,6 @@ def filter_change_points_by_median_threshold(
value of threshold is 0.05.
"""
valid_change_points = []
epsilon = 1e-10 # needed to avoid division by zero.

for idx in change_points:
if idx == 0 or idx == len(data):
Expand All @@ -331,11 +330,6 @@ def filter_change_points_by_median_threshold(
(left_mad + right_mad)):
valid_change_points.append(idx)
continue

relative_change = abs(right_value - left_value) / (left_value + epsilon)

if relative_change > threshold:
valid_change_points.append(idx)
return valid_change_points


Expand Down
Loading