Where a Throwable is being caught, take care to rethrow OutOfMemoryError#37748
Where a Throwable is being caught, take care to rethrow OutOfMemoryError#37748scwhittle wants to merge 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the stability and reliability of Apache Beam's Java runners and SDK components by implementing more robust Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
kennknowles
left a comment
kennknowles
left a comment
There was a problem hiding this comment.
Just one that I don't like. The rest LGTM. I'm also suspicious of how often we catch Throwables, vs having some upleveled retry loop, but I understand that issue is out of scope here.
| } catch (OutOfMemoryError oom) { | ||
| throw oom; | ||
| } catch (Throwable t) { | ||
| throw wrapUserCodeException(t); |
There was a problem hiding this comment.
I'm not so sure we want to wrap every Throwable here. (and if you don't make that change, you don't need the special case)
There was a problem hiding this comment.
I was making this consistent with start and finish, but I can make them consistent by changing it the other way so that just Exceptions are wrapped :)
There is some risk if customer code is throwing Errors that we are changing behavior, but that seems like bad practice and they could just add catches themselves.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
2 participants
This ensures that they are not swallowed leaving the JVM in possibly broken state.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.