[ErrorProne] Enable LongDoubleConversion check

[stankiewicz]

This PR removes the LongDoubleConversion check from the disabled check list in ErrorProne configuration (BeamModulePlugin.groovy) and resolves the warnings it uncovered across the codebase. `

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances code quality by activating the LongDoubleConversion ErrorProne check. This check identifies potential precision loss when converting long to double. The changes involve removing the check from the disabled list and applying explicit type casting in several locations to prevent implicit conversions and ensure correct numerical operations across the codebase.

Highlights

• ErrorProne Check Enabled: The LongDoubleConversion ErrorProne check has been enabled by removing it from the disabled checks list in the Gradle configuration.
• Type Casting for Precision: Explicit (double) casts were added in several Java files to resolve warnings identified by the LongDoubleConversion check, preventing potential precision loss during long to double conversions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
  • Removed LongDoubleConversion from the list of disabled ErrorProne checks.
• sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
  • Added explicit (double) cast to estimatedSize before Math.sqrt.
  • Added explicit (double) cast to size when creating a Progress object.
• sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java
  • Added explicit (double) cast to maxNumElements in the withMaxInputSize method.
  • Added explicit (double) casts to newWeight and offset(newWeight) in the collapse method.
• sdks/java/core/src/main/java/org/apache/beam/sdk/util/FluentBackoff.java
  • Added explicit (double) cast to backoffConfig.maxBackoff.getMillis() in the nextBackOffMillis calculation.
• sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTrackerTest.java
  • Updated assertEquals assertions with explicit (double) casts for getWorkCompleted and getWorkRemaining values to match expected double types.

Activity

• No human activity has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[stankiewicz]

Run Java PreCommit

[stankiewicz]

/gemini review

[gemini-code-assist]

Code Review

This pull request enables the LongDoubleConversion check in ErrorProne and applies the necessary fixes across the codebase. The changes consistently add explicit (double) casts where long values were being implicitly converted to double, which is the correct way to resolve these warnings. This improves code clarity and makes developers aware of potential precision loss. All the modifications look correct and I have no further suggestions.

[stankiewicz]

Run Java PreCommit

[github-actions]

Assigning reviewers:

R: @kennknowles for label java.
R: @damccorm for label build.
R: @johnjcasey for label kafka.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).