Skip to content

Enable multi-release attribute for Spark job server jar#38449

Open
Abacn wants to merge 1 commit into
apache:masterfrom
Abacn:enable-multi-release
Open

Enable multi-release attribute for Spark job server jar#38449
Abacn wants to merge 1 commit into
apache:masterfrom
Abacn:enable-multi-release

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented May 11, 2026

Remove leftover of corrupt gradle cache workaround added before

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Spark job server build configuration to enable multi-release JAR support. It also cleans up a previous workaround related to gradle caching, streamlining the build process for the shadow jar.

Highlights

  • Multi-Release Manifest Attribute: Added the 'Multi-Release' attribute to the Spark job server jar manifest to support multi-release JAR functionality.
  • Build Configuration Cleanup: Removed the 'outputs.upToDateWhen { false }' workaround that was previously used to bypass potential gradle cache corruption issues.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented May 11, 2026

R: @tkaymak

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the shadowJar task configuration in spark_job_server.gradle by removing a Gradle cache workaround and adding a Multi-Release manifest attribute. The reviewer suggests splitting these logically distinct changes into separate pull requests to improve commit history and maintainability.

Comment on lines 309 to 313
shadowJar {
outputs.upToDateWhen { false }
manifest {
attributes(["Multi-Release": true])
}
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This pull request combines two logically separate changes:

  1. Removing the Gradle cache workaround (outputs.upToDateWhen { false }).
  2. Enabling the Multi-Release manifest attribute.

Combining unrelated changes in a single pull request can make the commit history harder to follow and complicates tasks like reverting or cherry-picking commits. It is recommended to submit separate pull requests for each distinct logical change.

Please consider splitting these changes into two separate pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant