Expose StorageWriteApiMaxRequestCallbackWaitTimeSec in BQ storage write.

[claudevdm]

#38304

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a configurable timeout for the BigQuery Storage Write API request callback queue. By exposing this parameter, users can now override the default 5-minute timeout to better suit their specific pipeline performance and reliability requirements.

Highlights

• Configuration Option Added: Introduced 'StorageWriteApiMaxRequestCallbackWaitTimeSec' to BigQueryOptions, allowing users to configure the maximum wait time for append request callbacks.
• Implementation in BigQueryServicesImpl: Updated BigQueryServicesImpl to capture the new configuration and apply it to the StreamWriter via 'setMaxRequestCallbackWaitTime' when initialized.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[claudevdm]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new configuration option, storageWriteApiMaxRequestCallbackWaitTimeSec, to allow users to override the default timeout for Storage Write API append requests. The review feedback highlights a significant concern regarding the use of a static setter in the underlying library, which introduces global side effects across the JVM and potential race conditions. Additionally, it is recommended to change the data type of the new option from Integer to Long to maintain consistency with other duration-based settings in BigQueryOptions.

[gemini-code-assist]

Code Review

This pull request introduces a new configuration option, storageWriteApiMaxRequestCallbackWaitTimeSec, to allow users to override the default timeout for Storage Write API append requests. The reviewer suggested several improvements for consistency and safety: switching the data type from Integer to Long to match the underlying library's expectations, providing a default value of 300 seconds to avoid side effects on global static state, and ensuring the timeout value is positive before application.

[Abacn]

it's a little bit strange that setMaxRequestCallbackWaitTime is a public static method.

This means users have a workaround that is to set it directly using a JvmInitializer or other mechanism before this gets released

[Abacn]

Thanks, this LGTM

[github-actions]

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).