Skip to content

Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure #4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liangyepianzhou wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −4
Open

Handling outdated and misleading comments in maybeHandleDelayedWriteBookieFailure #4653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2148,10 +2148,8 @@ void maybeHandleDelayedWriteBookieFailure() {
return;
}

// Original intent of this change is to do a best-effort ensemble change.
// But this is not possible until the local metadata is completely immutable.
// Until the feature "Make LedgerMetadata Immutable #610" Is complete we will use
// handleBookieFailure() to handle delayed writes as regular bookie failures.
// Treat delayed-write failures as regular bookie failures and trigger an ensemble change.
// LedgerMetadata is immutable now (#281), so this is handled via MetadataUpdateLoop.
handleBookieFailure(toReplace);
}

Expand Down
Loading