build(test): generate per-file brpc cc_test to improve Bazel UT coverage#2985
Open
XueSongTap wants to merge 12 commits intoapache:masterfrom
Open
build(test): generate per-file brpc cc_test to improve Bazel UT coverage#2985XueSongTap wants to merge 12 commits intoapache:masterfrom
XueSongTap wants to merge 12 commits intoapache:masterfrom
Conversation
Signed-off-by: yexiaochuan <tap91624@gmail.com>
… license header Signed-off-by: yexiaochuan <tap91624@gmail.com>
Signed-off-by: yexiaochuan <tap91624@gmail.com>
Contributor
|
Is it possible to use bazel tests with github workflows? |
Contributor
Author
|
Sure, i"ll work on workflow |
wwbmmm
reviewed
Aug 18, 2025
Contributor
|
This code looks no problem, but I don't know why the ci-linux workflow is not runned… |
chenBright
reviewed
Aug 30, 2025
Signed-off-by: yexiaochuan <tap91624@gmail.com>
chenBright
reviewed
Aug 31, 2025
| - name: run bazel tests | ||
| run: bazel test --test_output=errors --verbose_failures -- //test/... | ||
|
|
||
| clang-bazel-unittest: |
Contributor
There was a problem hiding this comment.
StackTraceTest.find_symbol seems to fail in clang14. It is recommended to use clang12 with sudo apt-get install -y clang-12 lldb-12 lld-12.
Contributor
There was a problem hiding this comment.
And --action_env=CC=clang-12.
chenBright
reviewed
Aug 31, 2025
Contributor
chenBright
left a comment
There was a problem hiding this comment.
Build on Macos has been fixed in master. Please update and rebase master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Part: #2904
Problem Summary:
test/brpc_http_rpc_protocol_unittest.cpp的修改是为了兼容bazel指定的 更高的proto版本 基于Bazel编译的UT不完善 #2904 (comment)What is changed and the side effects?
Changed:
brpc/test/CMakeLists.txt
Line 253 in c24e641
Side effects:
Performance effects:无
Breaking backward compatibility: 无
Check List: