detect and negotiate mtu#3304
Open
randomkang wants to merge 2 commits into
Open
Conversation
chenBright
reviewed
May 19, 2026
| uint32_t block_size; | ||
| uint16_t sq_size; | ||
| uint16_t rq_size; | ||
| uint16_t mtu_type; |
Contributor
There was a problem hiding this comment.
To maintain forward compatibility with the handshake protocol, mtu_type needs to be added to the end.
| uint16_t detect_mtu(struct ibv_context* ctx, int port_num) { | ||
| struct ibv_port_attr port_attr; | ||
|
|
||
| if (ibv_query_port(ctx, port_num, &port_attr)) { |
Contributor
There was a problem hiding this comment.
Only one MTU type detection is needed in GlobalRdmaInitializeOrDie(). It doesn't need to be detected on every handshake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
The bandwith of rdma perf will be increased 25%(in my case, from 33GB/s to 41GB/s ).
Check List: