[DRAFT][ci] Install mysql-server for MySQL handshake integration tests#3318
Closed
rajvarun77 wants to merge 1 commit into
Closed
[DRAFT][ci] Install mysql-server for MySQL handshake integration tests#3318rajvarun77 wants to merge 1 commit into
rajvarun77 wants to merge 1 commit into
Conversation
The MySQL auth handshake integration test (added in the mysql codec PR apache#3310) spins up a throwaway mysqld via the which-then-spawn pattern from test/brpc_redis_unittest.cpp, skipping when the binary is absent. Install mysql-server in both make-based unittest jobs so the test actually runs in CI; symlink mysqld onto PATH and stop the system service so the test owns the default port. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
Closing — reverting all CI pipeline changes for now; the mysql-server install step will be revisited separately if/when the handshake integration test in #3310 lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs
mysql-serverin the two make-based Linux unittest jobs (clang-unittest,clang-unittest-asan) so the MySQL auth handshake integration test can run in CI instead of self-skipping. The test (added in #3310) brings up a throwawaymysqldvia thewhich-then-spawn pattern fromtest/brpc_redis_unittest.cpp; this step symlinksmysqldonto PATH and stops the system service so the test owns the default port. Split out of #3310 to keep that PR's diff to the codec + tests. Depends on #3310 landing first (the test it enables ships there); harmless until then — it just installs an unused package.🤖 Generated with Claude Code