CAMEL-22635: Fix LogCaptureTest in camel-netty and camel-netty-http#22083
Merged
CAMEL-22635: Fix LogCaptureTest in camel-netty and camel-netty-http#22083
Conversation
The LogCaptureAppender was disabled because the Log4j2 plugin discovery via configuration.packages no longer works reliably. Fix by programmatically attaching the appender to the logger in setUp/tearDown, removing the dependency on log4j2.properties plugin configuration. Also remove @disabled annotation and add @isolated to prevent interference with other tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
Full reactor (4 modules)
|
Contributor
|
/component-test netty netty-http |
Contributor
|
✅
|
apupier
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogCaptureAppenderto the logger insetUp/tearDowninstead of relying onconfiguration.packagesplugin discovery inlog4j2.properties(deprecated in Log4j2 2.x)@Disabledannotation from bothcamel-nettyandcamel-netty-httpLogCaptureTestlog4j2.properties— remove broken appender reference that caused NPE at startup@Isolatedto prevent interference with other testsTest plan
LogCaptureTestpasses in camel-nettyLogCaptureTestpasses in camel-netty-http