CAMEL-23431: Migrate thrift tests from AvailablePortFinder to port-0 binding#23019
Open
gnodet wants to merge 1 commit intoapache:mainfrom
Open
CAMEL-23431: Migrate thrift tests from AvailablePortFinder to port-0 binding#23019gnodet wants to merge 1 commit intoapache:mainfrom
gnodet wants to merge 1 commit intoapache:mainfrom
Conversation
…binding Add getLocalPort() to ThriftConsumer to expose the OS-assigned port. Producer tests (ThriftProducerBaseTest, ThriftProducerSecurityTest, ThriftProducerZlibCompressionTest, ThriftThreadPoolServerTest) now create servers with port 0 in doPreSetup() and read back the actual port. Consumer tests use port 0 in from() URI and read back the port from ThriftConsumer after context start. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (8 modules)
|
davsclaus
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAMEL-23431
Summary
Third PR for CAMEL-23431. Migrates all
camel-thrifttests (10 test files) fromAvailablePortFinderto port-0 binding, completely eliminatingAvailablePortFinderfrom the thrift module.Production code:
getLocalPort()toThriftConsumerto expose the OS-assigned port after server startProducer tests (create own server):
ThriftProducerBaseTest: Move server creation todoPreSetup(), bindTNonblockingServerSocketto port 0ThriftProducerSecurityTest: Same pattern withTSSLTransportFactoryThriftProducerZlibCompressionTest: Same pattern withTServerSocketThriftThreadPoolServerTest: Bind to port 0 in@BeforeEachConsumer tests (Camel component creates server):
from()URI, then read back actual port fromThriftConsumer.getLocalPort()for client connectionsThriftConsumerConcurrentTest: 2 ports (sync + async) both use port 0Test plan
mvn testincamel-thrift— 39 tests pass