CAMEL-23431: Migrate camel-grpc and camel-mllp tests from AvailablePortFinder to port-0 binding#23037
Draft
gnodet wants to merge 3 commits intoapache:mainfrom
Draft
CAMEL-23431: Migrate camel-grpc and camel-mllp tests from AvailablePortFinder to port-0 binding#23037gnodet wants to merge 3 commits intoapache:mainfrom
gnodet wants to merge 3 commits intoapache:mainfrom
Conversation
…rtFinder to port-0 binding - Add getLocalPort() to GrpcConsumer to expose OS-assigned port - Allow port 0 in GrpcConsumer by changing port check from > 0 to >= 0 - Add getLocalPort() to MllpTcpServerConsumer to expose OS-assigned port - Migrate all grpc and mllp tests to use port 0 instead of AvailablePortFinder Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
…hread The serverSocket field is package-private, so access it via a public getter instead of direct field access from MllpTcpServerConsumer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Shorten java.util.concurrent.TimeUnit to import + simple name to satisfy the OpenRewrite FQCN check in CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
@gnodet can you update this PR as it has merge conflicts now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAMEL-23431
Migrate
camel-grpcandcamel-mllptests fromAvailablePortFinderto port-0ServerSocketbinding, eliminating TOCTOU race conditions that can cause flakyBindExceptionfailures.Changes
camel-grpc
getLocalPort()toGrpcConsumerto expose the OS-assigned port after server start> 0to>= 0to allow port 0 (OS-assigned)camel-mllp
getLocalPort()toMllpTcpServerConsumerto expose the OS-assigned portTest plan