Skip to content

CASSANALYTICS-188: Expand list of architecture that supports unaligned access in FastByteOperations #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarankk merged 2 commits into from
Aug 4, 2026
+10 −1
Merged

CASSANALYTICS-188: Expand list of architecture that supports unaligned access in FastByteOperations #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be8f25c
Expand list of architecture for unaligned support
sarankk Aug 4, 2026
362c437
Add comment
sarankk Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
0.5.0
-----
* Expand list of architecture that supports unaligned access in FastByteOperations (CASSANALYTICS-188)
* Fix FastByteOperations Silently Falling Back to Pure-Java Comparator (CASSANALYTICS-187)
* AbstractSchemaBuilder.build() drops the cdc flag, silently disabling CDC on all tables (CASSANALYTICS-186)
* Fix total timeout calculation for getAllNodeSettings (CASSANALYTICS-179)
Expand Down
10 changes: 9 additions & 1 deletion ...ics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/util/FastByteOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,15 @@ private static class BestHolder
static ByteOperations getBest()
{
String arch = System.getProperty("os.arch");
boolean unaligned = arch.equals("i386") || arch.equals("x86") || arch.equals("x86_64") || arch.equals("amd64");
// Note that s390x, aarch64, & ppc64le architectures are not officially supported and adding them here is only done out
// of convenience for those that want to run C* on these architectures at their own risk (see #11214, #13326, & #13615)
boolean unaligned = arch.equals("i386")

@yifan-c yifan-c Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the same disclaimer as in Cassandra source code.

    // Note that s390x, aarch64, & ppc64le architectures are not officially supported and adding them here is only done out
    // of convenience for those that want to run C* on these architectures at their own risk (see #11214, #13326, & #13615)

#11214 refers to CASSANDRA-11214

|| arch.equals("x86")
|| arch.equals("x86_64")
|| arch.equals("amd64")
|| arch.equals("s390x")
|| arch.equals("aarch64")
|| arch.equals("ppc64le");
if (!unaligned)
{
return new PureJavaOperations();
Expand Down
Loading