Enable trickle fsync by default - #5032
Open
samueldlightfoot wants to merge 1 commit into
Open
Conversation
Replace getTrickleFsyncIntervalInKiB with getTrickleFsyncIntervalInBytes. The interval accepts up to Integer.MAX_VALUE KiB, so KiB * 1024 in int arithmetic overflowed above 2 GiB and could wrap negative, fsyncing every buffer. Widen the writer's counter and the option's interval to long for the same reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace getTrickleFsyncIntervalInKiB with getTrickleFsyncIntervalInBytes. The interval accepts up to Integer.MAX_VALUE KiB, so KiB * 1024 in int arithmetic overflowed above 2 GiB and could wrap negative, fsyncing every buffer. Widen the writer's counter and the option's interval to long for the same reason.
patch by Sam Lightfoot; reviewed by for CASSANDRA-21572