Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds administrator documentation for the new Key Management Service (KMS) feature and wires it into the Admin Guide, including updated volume creation docs and supporting UI/architecture screenshots.
Changes:
- Add a new Admin Guide page documenting KMS concepts (KEK/DEK), HSM profiles, key lifecycle (create/rotate), migration, and configuration settings.
- Update storage docs to describe KVM volume encryption and expose the new “KMS Key” option when creating volumes.
- Add new images and include the new KMS page in the Admin Guide index toctree.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| source/adminguide/storage.rst | Adds a “Volume Encryption” section and documents the optional “KMS Key” field during volume creation. |
| source/adminguide/kms.rst | New KMS documentation page (architecture, providers, HSM profiles, key creation/rotation, migration, settings). |
| source/adminguide/index.rst | Adds kms to the Admin Guide toctree so the new page is published. |
| source/_static/images/kms-rotate-key.png | New screenshot referenced by KMS key rotation docs. |
| source/_static/images/kms-create-key.png | New screenshot referenced by KMS key creation docs. |
| source/_static/images/kms-architecture.png | New architecture diagram referenced by the KMS overview. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after: apache/cloudstack#12711
📚 Documentation preview 📚: https://cloudstack-documentation--634.org.readthedocs.build/en/634/