Notify user if template upgrade is not required

[sudo87]

Description

This PR adds a notification in case Router is with latest template version . As of now it shows Upgrade is done, which gives wrong impression if no upgrade is performed.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Before:

After:

Log message:

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (8db7cab) to head (0e73ad0).
⚠️ Report is 7 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...ork/router/VirtualNetworkApplianceManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12483      +/-   ##
============================================
- Coverage     16.24%   16.23%   -0.01%     
+ Complexity    13393    13390       -3     
============================================
  Files          5657     5657              
  Lines        499107   499108       +1     
  Branches      60574    60574              
============================================
- Hits          81069    81055      -14     
- Misses       409001   409014      +13     
- Partials       9037     9039       +2     

Flag	Coverage Δ
uitests	4.03% <ø> (ø)
unittests	17.09% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm

[sureshanaparti]

clgtm

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16465

[RosiKyu]

LGTM

Test Case Summary

TC	Description	Path	Result
TC1	Router template upgrade rejected when not required	API	PASSED
TC2	Router template upgrade rejected when not required	UI	PASSED
TC3	Router template upgrade succeeds when upgrade is required	API	PASSED

TC1: Router template upgrade is not required - API path

Objective: Attempt upgrade via API if no upgrade required

Expected Result: API should reject the attempt with an appropriate error message

Actual Result API rejects the attempt with an appropriate error msg

Test Evidence:

(localcloud) 🐱 > upgradeRouterTemplate id=084973aa-fb35-405c-90fc-260dd7e51db5
🙈 Error: (HTTP 530, error code 4250) Router is already at the latest version. No upgrade required

TC2: Router template upgrade is not required - UI path

Objective: Attempt upgrade via UI if no upgrade required

Expected Result: UI should display an appropriate error message

Actual Result UI displays appropriate error msg

Test Evidence:

Logs Evidence

[root@ref-trl-10696-k-Mol9-rositsa-kyuchukova-mgmt1 ~]# cat /var/log/cloudstack/management/management-server.log | grep -i "already at the latest"
2026-01-23 14:58:35,494 DEBUG [c.c.n.r.VpcVirtualNetworkApplianceManagerImpl] (qtp2038105753-25:[ctx-93a9a23f, ctx-3b6a687a, ctx-09d3ee75]) (logid:7840aa0a) Router: VM instance {"id":4,"instanceName":"r-4-VM","state":"Running","type":"DomainRouter","uuid":"084973aa-fb35-405c-90fc-260dd7e51db5"} is already at the latest version. No upgrade required
2026-01-23 14:58:35,495 ERROR [c.c.a.ApiServer] (qtp2038105753-25:[ctx-93a9a23f, ctx-3b6a687a, ctx-09d3ee75]) (logid:7840aa0a) unhandled exception executing api command: [Ljava.lang.String;@3f9601ee com.cloud.utils.exception.CloudRuntimeException: Router is already at the latest version. No upgrade required
2026-01-23 14:59:43,330 DEBUG [c.c.n.r.VpcVirtualNetworkApplianceManagerImpl] (qtp2038105753-22:[ctx-6a7ccb59, ctx-0125cb45]) (logid:d7d1c3f7) Router: VM instance {"id":4,"instanceName":"r-4-VM","state":"Running","type":"DomainRouter","uuid":"084973aa-fb35-405c-90fc-260dd7e51db5"} is already at the latest version. No upgrade required
2026-01-23 14:59:43,330 ERROR [c.c.a.ApiServer] (qtp2038105753-22:[ctx-6a7ccb59, ctx-0125cb45]) (logid:d7d1c3f7) unhandled exception executing api command: [Ljava.lang.String;@62f0692f com.cloud.utils.exception.CloudRuntimeException: Router is already at the latest version. No upgrade required

TC3: Router template upgrade possible when upgrade is required

Objective Verify router template upgrade succeeds when router uses outdated SystemVM template

Actual Result: API returns async job ID (upgrade triggered)

Test Evidence

(localcloud) 🐱 > upgradeRouterTemplate id=084973aa-fb35-405c-90fc-260dd7e51db5
{
  "asyncjobs": [
    {
      "jobid": "d01c5007-6282-4c99-a7a1-7c54dc124c29"
    }
  ],
  "count": 1
}