Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR fixes issue with build due to unit test failure caused by: #12499

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.24%. Comparing base (fa3dee8) to head (d3a6902).
⚠️ Report is 1 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##              4.20   #12520       +/-   ##
============================================
+ Coverage     4.03%   16.24%   +12.21%     
- Complexity       0    13397    +13397     
============================================
  Files          402     5658     +5256     
  Lines        32721   499224   +466503     
  Branches      5832    60595    +54763     
============================================
+ Hits          1319    81100    +79781     
- Misses       31247   409081   +377834     
- Partials       155     9043     +8888     
Flag Coverage Δ
uitests 4.03% <ø> (ø)
unittests 17.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

@Pearl1594
Copy link
Contributor Author

Merging - as build succeeded.

@Pearl1594 Pearl1594 merged commit 5bb5af4 into 4.20 Jan 26, 2026
49 checks passed
@Pearl1594 Pearl1594 deleted the fix-test branch January 26, 2026 16:33
@DaanHoogland DaanHoogland added this to the 4.20.3 milestone Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants