server: set template type to ROUTING or USER if template type is not specified when upload a template

[weizhouapache]

Description

This PR fixes #12763

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@DaanHoogland @vishesh92 @vladimirpetrov
do you think we should set the template type to USER in the upgrade sql ?

UPDATE `cloud`.`vm_template` SET `type` = "USER" WHERE `type` IS NULL;

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

@DaanHoogland @vishesh92 @vladimirpetrov
do you think we should set the template type to USER in the upgrade sql ?

UPDATE `cloud`.`vm_template` SET `type` = "USER" WHERE `type` IS NULL;

Sounds good, is type null leading to NPEs?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.61%. Comparing base (c3d6a8c) to head (e01730a).
⚠️ Report is 2 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/template/TemplateManagerImpl.java	0.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12768      +/-   ##
============================================
- Coverage     17.61%   17.61%   -0.01%     
- Complexity    15661    15662       +1     
============================================
  Files          5917     5917              
  Lines        531402   531404       +2     
  Branches      64971    64972       +1     
============================================
- Hits          93586    93585       -1     
- Misses       427262   427264       +2     
- Partials      10554    10555       +1     

Flag	Coverage Δ
uitests	3.70% <ø> (ø)
unittests	18.68% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

@DaanHoogland @vishesh92 @vladimirpetrov
do you think we should set the template type to USER in the upgrade sql ?

UPDATE `cloud`.`vm_template` SET `type` = "USER" WHERE `type` IS NULL;

Sounds good, is type null leading to NPEs?

I think it does not lead to NPEs, but template/iso are not usable as the type is NULL.
In several places (UI and source code), cloudstack only lists templates with USER template type.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 17039

[vishesh92]

clgtm. didn't test.

[vishesh92]

@blueorangutan package

[Copilot]

Pull request overview

Updates template upload/registration validation to default the template type to ROUTING or USER when not explicitly provided, and aligns existing DB records by backfilling vm_template.type when it is NULL.

Changes:

• Extend template-type defaulting logic to GetUploadParamsForTemplateCmd.
• Add permission validation/error for non-admin users requesting upload params for non-USER template types.
• Backfill cloud.vm_template.type to USER where it is currently NULL.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
server/src/main/java/com/cloud/template/TemplateManagerImpl.java	Default template type for upload-params requests and restrict non-admin usage for non-USER types.
engine/schema/src/main/resources/META-INF/db/schema-42200to42210.sql	Data migration to set vm_template.type to USER for existing NULL rows.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[weizhouapache]

@blueoranguran package

[weizhouapache]

@blueoranguran package

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17049

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests