Skip to content

UI: Show security group selection in Basic zone VM deployment#12775

Merged
sureshanaparti merged 1 commit intoapache:4.22from
Damans227:fix/11685-sg-selection-basic-zone
Mar 12, 2026
Merged

UI: Show security group selection in Basic zone VM deployment#12775
sureshanaparti merged 1 commit intoapache:4.22from
Damans227:fix/11685-sg-selection-basic-zone

Conversation

@Damans227
Copy link
Collaborator

Description

The Deploy VM wizard does not show the Security Groups selection step in Basic zones.

Fixes: #11685

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Screen-recording

Screen.Recording.2026-03-09.at.4.46.05.PM.mov

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

  1. Created a Basic zone and verified the Security Groups step now appears in the Deploy VM wizard
  2. Tested cross-domain deployment as root admin and verified SGs from the target domain/account are listed correctly

@Damans227
Copy link
Collaborator Author

@blueorangutan package

@blueorangutan
Copy link

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 17055

@weizhouapache
Copy link
Member

@blueorangutan package

@weizhouapache
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.61%. Comparing base (7aa0558) to head (7e45706).
⚠️ Report is 1 commits behind head on 4.22.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12775      +/-   ##
============================================
- Coverage     17.61%   17.61%   -0.01%     
  Complexity    15664    15664              
============================================
  Files          5917     5917              
  Lines        531402   531411       +9     
  Branches      64971    64972       +1     
============================================
- Hits          93596    93595       -1     
- Misses       427252   427262      +10     
  Partials      10554    10554              
Flag Coverage Δ
uitests 3.70% <ø> (-0.01%) ⬇️
unittests 18.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache linked an issue Mar 10, 2026 that may be closed by this pull request
@weizhouapache
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12775 (QA-JID-894)

@Damans227 Damans227 added the complexity:multple-issues this issues descibes multple implementation requests or bugs label Mar 10, 2026
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17074

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@Damans227 Damans227 removed the complexity:multple-issues this issues descibes multple implementation requests or bugs label Mar 10, 2026
@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12775 (QA-JID-896)

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested on the QA server

Image

@sureshanaparti sureshanaparti merged commit 71daf84 into apache:4.22 Mar 12, 2026
20 of 26 checks passed
@Damans227 Damans227 deleted the fix/11685-sg-selection-basic-zone branch March 12, 2026 13:41
@Damans227 Damans227 restored the fix/11685-sg-selection-basic-zone branch March 12, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

UI: No Security group Section in DeployVm wizard in Basic zone

6 participants