sharedfs: skip hypervisors without system templates - #13830
Open
Dogface2k wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13830 +/- ##
============================================
- Coverage 17.69% 17.69% -0.01%
Complexity 15835 15835
============================================
Files 5925 5925
Lines 533539 533541 +2
Branches 65274 65275 +1
============================================
- Hits 94427 94424 -3
- Misses 428435 428442 +7
+ Partials 10677 10675 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@blueorangutan package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13825
Summary
Prevent
CreateSharedFileSystemfrom dereferencing a missing system VM template when a zone contains mixed hypervisor types.Root cause
deploySharedFSVM()shuffles the supported hypervisors. When a hypervisor has no ready system VM template and another hypervisor remains, the existing null check fell through totemplate.getId()instead of trying the next hypervisor. This caused the reported intermittent NPE for mixed zones such as VMware plus External/MaaS.Fix
Skip hypervisors without a ready system VM template while alternatives remain. Preserve the existing explicit
CloudRuntimeExceptionwhen the final candidate also has no template.Validation
template is nullNPE occurred on the External-first attempt.4.22branch with the exact NPE.Scope
This is limited to SharedFS hypervisor template selection and its regression test. No UI, API contract, database schema, or deployment behavior is changed.