fix: Support scalar/array args for rpad/read_side_padding#2482
Draft
wForget wants to merge 5 commits intoapache:mainfrom
Draft
fix: Support scalar/array args for rpad/read_side_padding#2482wForget wants to merge 5 commits intoapache:mainfrom
wForget wants to merge 5 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
============================================
+ Coverage 56.12% 58.40% +2.28%
- Complexity 976 1436 +460
============================================
Files 119 146 +27
Lines 11743 13510 +1767
Branches 2251 2350 +99
============================================
+ Hits 6591 7891 +1300
- Misses 4012 4389 +377
- Partials 1140 1230 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Failed spark test case: |
Contributor
|
@coderfender as were working on rpad/lpad |
Member
Author
Thank you for the info, feel free to take over this. |
Contributor
|
@wForget , If my understanding is right, you are adding support to non scalar args to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2475.
Rationale for this change
Support full scalar/array arguments for rpad/read_side_padding
What changes are included in this PR?
Use
make_scalar_functionto convert arguments to arrays.How are these changes tested?
unit test