Conversation
comphead
left a comment
There was a problem hiding this comment.
Thanks @Shekharrajak for you contribution, please add a function to the fuzztesting kit, similar to #2755
|
In the past I think we've encountered differences in Java and Rust's regex engines wrt graphemes. Could we get some larger UTF-8 characters in the tests? |
We probably need to fall back to Spark unless this config is enabled: |
Thanks! Added in commit 8eddd29 |
Added tests 987b646 |
How can we check if it is not falling back to Spark's JVM execution? @andygrove |
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
Outdated
Show resolved
Hide resolved
dbb34d5 to
1f8f2b2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2772 +/- ##
============================================
+ Coverage 56.12% 60.03% +3.90%
- Complexity 976 1428 +452
============================================
Files 119 170 +51
Lines 11743 15809 +4066
Branches 2251 2608 +357
============================================
+ Hits 6591 9491 +2900
- Misses 4012 5000 +988
- Partials 1140 1318 +178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @Shekharrajak Perhaps you can try |
I ran but I am not sure why the checks keep failing |
|
Please trigger the workflow. |
|
All checks are looking fine. This is ready to merge. |
e7b267b to
c0a22b8
Compare
|
Updated the branch with latest main branch. Please trigger the workflow |
Fixes #2707
We have scalar function:
https://datafusion.apache.org/user-guide/sql/scalar_functions.html#string-to-array