fix: [branch-0.14] backport #3914 - use min instead of max when capping write buffer size to Int range#3936
Merged
andygrove merged 1 commit intoapache:branch-0.14from Apr 14, 2026
Conversation
…ge (apache#3914) COMET_SHUFFLE_WRITE_BUFFER_SIZE is a Long (bytesConf) but the protobuf field is int32, so the value must be capped at Int.MaxValue. The code used .max(Int.MaxValue) which always returns Int.MaxValue (~2GB) regardless of the configured value. Should be .min(Int.MaxValue) to preserve smaller values while capping at the Int range.
andygrove
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Backport of #3914 to branch-0.14.
Rationale for this change
PR #3914 fixes a bug where
maxwas used instead ofminwhen capping the write buffer size to the Int range.What changes are included in this PR?
Cherry-pick of commit 967a81e from main. A one-line fix changing
maxtominwhen capping the write buffer size.How are these changes tested?
Covered by existing tests in the original PR.