Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ankaushik/datafusion-site into feat/dark-mode-support
There was a problem hiding this comment.
Pull request overview
This pull request implements dark mode support for the Apache DataFusion blog website, addresses multiple spelling errors across historical blog posts, and introduces automated spell checking via a new GitHub Actions workflow.
Changes:
- Implements a comprehensive dark mode feature with toggle button, CSS variables, and localStorage persistence
- Corrects 9 spelling errors across 7 blog posts (retrieve, libraries, performance, Aggregate, initialization, threshold, publicly, including, MemoryManager)
- Adds automated typo checking workflow using the
typostool to prevent future spelling errors
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| content/theme/templates/styles.html | Adds references to dark mode CSS and JavaScript files |
| content/theme/templates/menu.html | Adds theme toggle button to navigation bar with accessibility attributes |
| content/js/darkmode.js | Implements dark mode toggle functionality with localStorage persistence and system preference detection |
| content/css/darkmode.css | Provides comprehensive dark mode styling with GitHub-inspired color palette and responsive design |
| content/blog/*.md (7 files) | Corrects spelling errors in blog posts |
| _typos.toml | Configures typo checker with custom dictionary and ignore patterns |
| .github/workflows/typo-check.yml | Adds GitHub Actions workflow for automated spell checking on blog posts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Could you rebase the branch to remove the typo changes, and attach some screenshots of this working locally?
|
|
hey @Jefffrey i try to make website look little good if this changes are not suitable i will change it as it's original design |
|
I think the CSS theme is changing too much between dark/light mode here; can we keep the changes related to colour only and not introduce changes like the boxes around each post? |
yeah sure i will do that |
|
hey @Jefffrey if this is okay i will push this changes ? |
|
hey @Jefffrey |
|
Thankyou for your feedback i will surely fixed all this bugs and update you. |
|
hey @Jefffrey Video.Project.5.mp4Please review it when you get time and let me know if any further improvement are required or not . |
|
hey @Jefffrey can you please review this one |
|
Apologies, I have a large backlog to work through at the moment so it'll be a while before I'm able to take a look at this again |
|
hey @Jefffrey just quick followup when you get free please review this pr i am waiting for your response , |





Added dark mode support and toggle button for changing the mode (eg. ligh,dark)
also improve readability by adding some extra line of CSS
fixed issue : #146