Skip to content

recursive protection for parse_subexpr #2282

Merged
iffyio merged 2 commits intoapache:mainfrom
blaginin:db/subexpression-recursive
Mar 24, 2026
Merged

recursive protection for parse_subexpr #2282
iffyio merged 2 commits intoapache:mainfrom
blaginin:db/subexpression-recursive

Conversation

@blaginin
Copy link
Member

@blaginin blaginin commented Mar 22, 2026

in DataFusion, extended tests in dev mode currently crash: https://github.com/apache/datafusion/actions/runs/23399325600/job/68068392877#step:8:922

I think that's because of index/between/1/slt_good_0 - specifically because of a very deep sub expression which crashes the stack

@blaginin blaginin self-assigned this Mar 22, 2026
@blaginin blaginin requested a review from iffyio March 23, 2026 21:00
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @blaginin!

@iffyio iffyio added this pull request to the merge queue Mar 24, 2026
Merged via the queue into apache:main with commit 7c4eac3 Mar 24, 2026
10 checks passed
@blaginin blaginin deleted the db/subexpression-recursive branch March 24, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants