Do not require mut in memory reservation methods #19759
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Prerequisite for the following PRs:
Even if the api on the
MemoryPooldoes not require&mut selffor growing/shrinking the reserved size, the api inMemoryReservationdoes, making simple implementations irrepresentable without synchronization primitives. For example, the following would require aMutexfor concurrent access to theMemoryReservationin different threads, even though theMemoryPooldoesn't:What changes are included in this PR?
Make the methods in
MemoryReservationrequire&selfinstead of&mut selffor allowing concurrent shrink/grows from different tasks for the same reservation.Are these changes tested?
yes, by current tests
Are there any user-facing changes?
Users can now safely call methods of
MemoryReservationfrom different tasks without synchronization primitives.This is a backwards compatible API change, as it will work out of the box for current users, however, depending on their clippy configuration, they might see some new warnings about "unused muts" in their codebase.