fix: Fix array_to_string with columnar third arg#20536
Merged
goldmedal merged 2 commits intoapache:mainfrom Feb 27, 2026
Merged
fix: Fix array_to_string with columnar third arg#20536goldmedal merged 2 commits intoapache:mainfrom
array_to_string with columnar third arg#20536goldmedal merged 2 commits intoapache:mainfrom
Conversation
github-actions
bot
added
sqllogictest
goldmedal
reviewed
Feb 27, 2026
Contributor
goldmedal
left a comment
goldmedal
left a comment
There was a problem hiding this comment.
Thanks @neilconway. LGTM. I have only one suggestion for the test.
goldmedal
approved these changes
Feb 27, 2026
Contributor
|
Thanks @neilconway |
Contributor
Author
|
Thanks for the review, @goldmedal ! If you're keen to review more PRs that improve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The previous coding used the
null_stringvalue for the first row as the value for the remainder of the rows. This is wrong ifnull_stringis columnar.What changes are included in this PR?
Are these changes tested?
Yes; added new SLT test.
Are there any user-facing changes?
No, other than fixing the behavior of
array_to_stringin this scenario.