Draft
Conversation
Add rule-level timing traces for analyzer/optimizer passes and detailed type_coercion phase breakdowns to improve profiling and triage of planning bottlenecks. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid recomputing projection schemas when expression coercion makes no changes, and add safety checks plus tests to ensure schema equivalence remains intact. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop benchmark and rule timing instrumentation from analyzer/optimizer and keep only the projection skip-recompute optimization path in type coercion. Co-authored-by: Cursor <cursoragent@cursor.com>
Inline the projection skip condition with the map_data chain to keep the coercion flow concise while preserving the existing fast-path behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Clarify the projection schema recompute fast path by relying on the transformed flag and add invariant assertions that no-op rewrites preserve schema Arc identity while rewritten projections force schema replacement. Co-authored-by: Cursor <cursoragent@cursor.com>
Only skip projection schema recomputation when rewritten expressions are unchanged and the existing projection schema still matches names and types derived from the current input. Add a regression test for unchanged projection expressions with changed input types. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?