Add Null Type Coercions for Placeholders#20543
Open
cetra3 wants to merge 1 commit intoapache:mainfrom
Open
Conversation
github-actions
bot
added
logical-expr
cetra3
force-pushed
the
parameter_type_coercion
branch
from
50b4a69 to
9d4791f
Compare
Fix lints and tests
cetra3
force-pushed
the
parameter_type_coercion
branch
from
9d4791f to
8ca8542
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
At least this one: #19471 but might be others
Rationale for this change
This fixes a problem we have where placeholder types are
Null, and we need to add explicit type casts in the query.I.e, you can't use placeholders for
date_binfunctions:This works though (currently):
What changes are included in this PR?
Adds some extra type coercions
Are these changes tested?
Yes, new tests added
Are there any user-facing changes?
Not really?