feat: make DataFrame::create_physical_plan take &self instead of self#20562
Open
xanderbailey wants to merge 3 commits intoapache:mainfrom
Open
feat: make DataFrame::create_physical_plan take &self instead of self#20562xanderbailey wants to merge 3 commits intoapache:mainfrom
xanderbailey wants to merge 3 commits intoapache:mainfrom
Conversation
Previously `create_physical_plan` consumed the `DataFrame`, making it impossible to inspect (e.g. log) the physical plan and then execute the same `DataFrame` (e.g. via `write_parquet` or `collect`) without first cloning it. Since the method only needs `&LogicalPlan` (which it forwards to `SessionState::create_physical_plan`), there is no reason to take ownership. Changing the signature to `&self` makes the common pattern of "get plan for logging, then write/collect" work naturally. Also removes the now-unnecessary `self.clone()` in `DataFrame::cache` that was introduced for the same reason. https://claude.ai/code/session_01F2BMik1KryMgRGUi9tTRSs
xanderbailey
force-pushed
the
claude/physical-plan-without-consume-Z0dJp
branch
from
eb049e1 to
05fcdf5
Compare
neilconway
approved these changes
Feb 26, 2026
Contributor
neilconway
left a comment
neilconway
left a comment
There was a problem hiding this comment.
lgtm. Does this constitute an API change?
Looks like a few more clones we can cleanup:
- datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs:564
- datafusion/core/tests/physical_optimizer/aggregate_statistics.rs:380
- datafusion/core/tests/dataframe/mod.rs:101-102
Contributor
Author
|
Hmm, I think maybe technically yes, is a break though... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Previously
create_physical_planconsumed theDataFrame, making it impossible to inspect (e.g. log) the physical plan and then execute the sameDataFrame(e.g. viawrite_parquetorcollect) without first cloning it.Since the method only needs
&LogicalPlan(which it forwards toSessionState::create_physical_plan), there is no reason to take ownership. Changing the signature to&selfmakes the common pattern of "get plan for logging, then write/collect" work naturally.Also removes the now-unnecessary
self.clone()inDataFrame::cachethat was introduced for the same reason.What changes are included in this PR?
Changing
selfto&selfAre these changes tested?
Yes
Are there any user-facing changes?