fix: Set Substrait output types for expressions#20597
Open
wlhjason wants to merge 3 commits intoapache:mainfrom
Open
fix: Set Substrait output types for expressions#20597wlhjason wants to merge 3 commits intoapache:mainfrom
wlhjason wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
BinaryExprincludesoutput_type#15831.Rationale for this change
The Substrait producer did not set the ScalarFunction
output_typewhen converting binary expressions, which broke consumers relying on theoutput_type.What changes are included in this PR?
from_joinandfrom_betweento eliminate direct calls tomake_binary_op_scalar_funcoutput_typewhen converting several types of DataFusion expressions:Expr::BinaryExpr)Expr::Not)Expr::ScalarFunction)There are a few more places where the
output_typehas not been set, such asfrom_likeandfrom_in_list, as mentioned in #15831. I've left these out of scope here as fixing them would require more substantial code changes.Are these changes tested?
Yes, via a new unit test.
Are there any user-facing changes?
No, beyond the Substrait output fix.