Skip to content

Different morsel approach#20600

Draft
Dandandan wants to merge 56 commits intoapache:mainfrom
Dandandan:morsel5
Draft

Different morsel approach#20600
Dandandan wants to merge 56 commits intoapache:mainfrom
Dandandan:morsel5

Conversation

@Dandandan
Copy link
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

google-labs-jules bot and others added 30 commits February 22, 2026 13:12
This PR implements morsel-driven execution for Parquet files in DataFusion, enabling row-group level work sharing across partitions to mitigate data skew.

Key changes:
- Introduced `WorkQueue` in `datafusion/datasource/src/file_stream.rs` for shared pool of work.
- Added `morselize` method to `FileOpener` trait to allow dynamic splitting of files into morsels.
- Implemented `morselize` for `ParquetOpener` to split files into individual row groups.
- Cached `ParquetMetaData` in `ParquetMorsel` extensions to avoid redundant I/O.
- Modified `FileStream` to support work stealing from the shared queue.
- Implemented `Weak` pointer pattern for `WorkQueue` in `FileScanConfig` to support plan re-executability.
- Added `MorselizingGuard` to ensure shared state consistency on cancellation.
- Added `allow_morsel_driven` configuration option (enabled by default for Parquet).
- Implemented row-group pruning during the morselization phase for better efficiency.

Tests:
- Added `parquet_morsel_driven_execution` test to verify work distribution and re-executability.
- Added `parquet_morsel_driven_enabled_by_default` to verify the default configuration.

Co-authored-by: Dandandan <163737+Dandandan@users.noreply.github.com>
@github-actions github-actions bot added datasource Changes to the datasource crate physical-plan Changes to the physical-plan crate labels Feb 27, 2026
@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing morsel5 (73267e5) to e583fe9 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@Dandandan Dandandan changed the title Morsel5 Different morsel approach Feb 27, 2026
@alamb-ghbot
Copy link

Benchmark script failed with exit code 101.

Last 10 lines of output:

Click to expand
82 | pub mod merge_partitions;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: to create the module `merge_partitions`, create file "datafusion/physical-plan/src/merge_partitions.rs" or "datafusion/physical-plan/src/merge_partitions/mod.rs"
   = note: if there is a `mod merge_partitions` elsewhere in the crate already, import it with `use crate::...` instead

   Compiling datafusion-sql v52.1.0 (/home/alamb/arrow-datafusion2/datafusion/sql)
For more information about this error, try `rustc --explain E0583`.
error: could not compile `datafusion-physical-plan` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

@Dandandan
Copy link
Contributor Author

run benchmarks

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing morsel5 (5901ac5) to e583fe9 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and morsel5
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query    ┃        HEAD ┃     morsel5 ┃        Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │  2285.07 ms │  2295.60 ms │     no change │
│ QQuery 1 │   917.91 ms │   890.37 ms │     no change │
│ QQuery 2 │  1769.50 ms │  1773.26 ms │     no change │
│ QQuery 3 │  1025.46 ms │  1055.98 ms │     no change │
│ QQuery 4 │  2183.45 ms │  2174.53 ms │     no change │
│ QQuery 5 │ 28366.38 ms │ 28304.03 ms │     no change │
│ QQuery 6 │  3753.08 ms │  3720.88 ms │     no change │
│ QQuery 7 │  2704.40 ms │  2516.61 ms │ +1.07x faster │
└──────────┴─────────────┴─────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary      ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 43005.26ms │
│ Total Time (morsel5)   │ 42731.25ms │
│ Average Time (HEAD)    │  5375.66ms │
│ Average Time (morsel5) │  5341.41ms │
│ Queries Faster         │          1 │
│ Queries Slower         │          0 │
│ Queries with No Change │          7 │
│ Queries with Failure   │          0 │
└────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃        HEAD ┃     morsel5 ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0  │     2.55 ms │    12.25 ms │  4.81x slower │
│ QQuery 1  │    48.07 ms │    47.21 ms │     no change │
│ QQuery 2  │   133.18 ms │   140.01 ms │  1.05x slower │
│ QQuery 3  │   157.39 ms │   153.84 ms │     no change │
│ QQuery 4  │  1016.74 ms │   989.45 ms │     no change │
│ QQuery 5  │  1245.47 ms │  1244.01 ms │     no change │
│ QQuery 6  │     6.46 ms │     6.55 ms │     no change │
│ QQuery 7  │    53.01 ms │    53.67 ms │     no change │
│ QQuery 8  │  1357.95 ms │  1364.82 ms │     no change │
│ QQuery 9  │  1716.12 ms │  1784.59 ms │     no change │
│ QQuery 10 │   348.06 ms │   347.15 ms │     no change │
│ QQuery 11 │   400.69 ms │   403.63 ms │     no change │
│ QQuery 12 │  1196.55 ms │  1181.55 ms │     no change │
│ QQuery 13 │  1846.94 ms │  1888.21 ms │     no change │
│ QQuery 14 │  1206.11 ms │  1196.40 ms │     no change │
│ QQuery 15 │  1160.58 ms │  1145.27 ms │     no change │
│ QQuery 16 │  2397.83 ms │  2414.88 ms │     no change │
│ QQuery 17 │  2383.10 ms │  2400.47 ms │     no change │
│ QQuery 18 │  4571.59 ms │  4845.10 ms │  1.06x slower │
│ QQuery 19 │   117.92 ms │   118.13 ms │     no change │
│ QQuery 20 │  1753.97 ms │  1735.17 ms │     no change │
│ QQuery 21 │  2045.83 ms │  2011.73 ms │     no change │
│ QQuery 22 │  3499.68 ms │  3462.83 ms │     no change │
│ QQuery 23 │ 11772.37 ms │ 11696.47 ms │     no change │
│ QQuery 24 │   204.31 ms │   203.52 ms │     no change │
│ QQuery 25 │   442.26 ms │   443.60 ms │     no change │
│ QQuery 26 │   200.93 ms │   212.18 ms │  1.06x slower │
│ QQuery 27 │  2529.91 ms │  2542.87 ms │     no change │
│ QQuery 28 │ 23614.03 ms │ 21359.54 ms │ +1.11x faster │
│ QQuery 29 │   975.52 ms │   947.16 ms │     no change │
│ QQuery 30 │  1232.31 ms │  1209.81 ms │     no change │
│ QQuery 31 │  1257.40 ms │  1280.92 ms │     no change │
│ QQuery 32 │  4349.08 ms │  4168.08 ms │     no change │
│ QQuery 33 │  5302.95 ms │  5252.50 ms │     no change │
│ QQuery 34 │  5359.44 ms │  5611.06 ms │     no change │
│ QQuery 35 │  1832.42 ms │  1832.28 ms │     no change │
│ QQuery 36 │   183.16 ms │   178.26 ms │     no change │
│ QQuery 37 │    71.50 ms │    71.23 ms │     no change │
│ QQuery 38 │   110.30 ms │   108.71 ms │     no change │
│ QQuery 39 │   327.12 ms │   332.68 ms │     no change │
│ QQuery 40 │    41.10 ms │    38.88 ms │ +1.06x faster │
│ QQuery 41 │    34.91 ms │    33.52 ms │     no change │
│ QQuery 42 │    31.01 ms │    30.24 ms │     no change │
└───────────┴─────────────┴─────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary      ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 88537.85ms │
│ Total Time (morsel5)   │ 86500.46ms │
│ Average Time (HEAD)    │  2059.02ms │
│ Average Time (morsel5) │  2011.64ms │
│ Queries Faster         │          2 │
│ Queries Slower         │          4 │
│ Queries with No Change │         37 │
│ Queries with Failure   │          0 │
└────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃   morsel5 ┃       Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1  │ 102.69 ms │ 103.14 ms │    no change │
│ QQuery 2  │  32.74 ms │  33.60 ms │    no change │
│ QQuery 3  │  34.93 ms │  41.07 ms │ 1.18x slower │
│ QQuery 4  │  30.79 ms │  30.72 ms │    no change │
│ QQuery 5  │  91.82 ms │  89.79 ms │    no change │
│ QQuery 6  │  21.72 ms │  27.16 ms │ 1.25x slower │
│ QQuery 7  │ 159.65 ms │ 163.80 ms │    no change │
│ QQuery 8  │  40.60 ms │  40.39 ms │    no change │
│ QQuery 9  │ 103.85 ms │ 103.73 ms │    no change │
│ QQuery 10 │  68.81 ms │  68.60 ms │    no change │
│ QQuery 11 │  19.29 ms │  18.82 ms │    no change │
│ QQuery 12 │  51.32 ms │  51.82 ms │    no change │
│ QQuery 13 │  48.25 ms │  48.45 ms │    no change │
│ QQuery 14 │  15.37 ms │  14.93 ms │    no change │
│ QQuery 15 │  30.69 ms │  30.34 ms │    no change │
│ QQuery 16 │  28.71 ms │  28.71 ms │    no change │
│ QQuery 17 │ 141.96 ms │ 142.97 ms │    no change │
│ QQuery 18 │ 280.31 ms │ 281.98 ms │    no change │
│ QQuery 19 │  39.46 ms │  38.77 ms │    no change │
│ QQuery 20 │  58.08 ms │  56.69 ms │    no change │
│ QQuery 21 │ 183.10 ms │ 189.99 ms │    no change │
│ QQuery 22 │  22.91 ms │  22.99 ms │    no change │
└───────────┴───────────┴───────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary      ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 1607.05ms │
│ Total Time (morsel5)   │ 1628.48ms │
│ Average Time (HEAD)    │   73.05ms │
│ Average Time (morsel5) │   74.02ms │
│ Queries Faster         │         0 │
│ Queries Slower         │         2 │
│ Queries with No Change │        20 │
│ Queries with Failure   │         0 │
└────────────────────────┴───────────┘

@Dandandan
Copy link
Contributor Author

run benchmarks

@github-actions github-actions bot added the optimizer Optimizer rules label Feb 27, 2026
Dandandan and others added 2 commits February 27, 2026 20:27
These tests directly query per-partition statistics from DataSourceExec,
which returns unknown stats when wrapped by MergePartitionsExec.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Dandandan
Copy link
Contributor Author

show benchmark queue

@alamb-ghbot
Copy link

🤖 Hi @Dandandan, you asked to view the benchmark queue (#20600 (comment)).

Job User Benchmarks Comment
arrow-9369-3974348983.sh alamb arrow_reader arrow_reader_clickbench https://github.com/apache/arrow-rs/pull/9369#issuecomment-3974348983
20600_3974672245.sh Dandandan default https://github.com/apache/datafusion/pull/20600#issuecomment-3974672245
arrow-9118-3974757450.sh alamb arrow_reader_clickbench https://github.com/apache/arrow-rs/pull/9118#issuecomment-3974757450

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing morsel5 (db78f83) to e583fe9 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and morsel5
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query    ┃        HEAD ┃     morsel5 ┃    Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 0 │  2362.69 ms │  2262.71 ms │ no change │
│ QQuery 1 │   888.79 ms │   886.83 ms │ no change │
│ QQuery 2 │  1781.85 ms │  1728.43 ms │ no change │
│ QQuery 3 │  1065.42 ms │  1015.90 ms │ no change │
│ QQuery 4 │  2211.73 ms │  2192.94 ms │ no change │
│ QQuery 5 │ 28485.88 ms │ 28283.40 ms │ no change │
│ QQuery 6 │  3715.34 ms │  3720.41 ms │ no change │
│ QQuery 7 │  2713.78 ms │  2762.69 ms │ no change │
└──────────┴─────────────┴─────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary      ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 43225.47ms │
│ Total Time (morsel5)   │ 42853.30ms │
│ Average Time (HEAD)    │  5403.18ms │
│ Average Time (morsel5) │  5356.66ms │
│ Queries Faster         │          0 │
│ Queries Slower         │          0 │
│ Queries with No Change │          8 │
│ Queries with Failure   │          0 │
└────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃        HEAD ┃     morsel5 ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0  │     2.56 ms │    11.27 ms │  4.40x slower │
│ QQuery 1  │    48.20 ms │    43.73 ms │ +1.10x faster │
│ QQuery 2  │   131.96 ms │   122.01 ms │ +1.08x faster │
│ QQuery 3  │   154.52 ms │   138.54 ms │ +1.12x faster │
│ QQuery 4  │   996.22 ms │  1031.57 ms │     no change │
│ QQuery 5  │  1219.32 ms │  1183.66 ms │     no change │
│ QQuery 6  │     6.61 ms │     5.92 ms │ +1.12x faster │
│ QQuery 7  │    52.15 ms │    48.71 ms │ +1.07x faster │
│ QQuery 8  │  1364.51 ms │  1357.97 ms │     no change │
│ QQuery 9  │  1703.13 ms │  1641.11 ms │     no change │
│ QQuery 10 │   346.15 ms │   318.99 ms │ +1.09x faster │
│ QQuery 11 │   393.05 ms │   367.69 ms │ +1.07x faster │
│ QQuery 12 │  1169.77 ms │  1084.07 ms │ +1.08x faster │
│ QQuery 13 │  1920.26 ms │  1595.15 ms │ +1.20x faster │
│ QQuery 14 │  1212.25 ms │  1102.37 ms │ +1.10x faster │
│ QQuery 15 │  1164.67 ms │  1168.83 ms │     no change │
│ QQuery 16 │  2464.43 ms │  2420.85 ms │     no change │
│ QQuery 17 │  2448.84 ms │  2435.58 ms │     no change │
│ QQuery 18 │  5162.87 ms │  4685.04 ms │ +1.10x faster │
│ QQuery 19 │   122.87 ms │   107.61 ms │ +1.14x faster │
│ QQuery 20 │  1773.91 ms │  1539.70 ms │ +1.15x faster │
│ QQuery 21 │  2024.65 ms │  1891.05 ms │ +1.07x faster │
│ QQuery 22 │  3579.21 ms │  3404.61 ms │     no change │
│ QQuery 23 │ 16445.77 ms │ 12776.07 ms │ +1.29x faster │
│ QQuery 24 │   201.31 ms │   127.08 ms │ +1.58x faster │
│ QQuery 25 │   443.99 ms │   388.26 ms │ +1.14x faster │
│ QQuery 26 │   202.54 ms │   128.27 ms │ +1.58x faster │
│ QQuery 27 │  2553.39 ms │  2348.48 ms │ +1.09x faster │
│ QQuery 28 │ 23718.85 ms │ 22774.09 ms │     no change │
│ QQuery 29 │   979.56 ms │   917.95 ms │ +1.07x faster │
│ QQuery 30 │  1246.06 ms │  1178.20 ms │ +1.06x faster │
│ QQuery 31 │  1333.76 ms │  1205.10 ms │ +1.11x faster │
│ QQuery 32 │  4920.55 ms │  3975.17 ms │ +1.24x faster │
│ QQuery 33 │  5558.20 ms │  5349.42 ms │     no change │
│ QQuery 34 │  5698.72 ms │  5702.53 ms │     no change │
│ QQuery 35 │  1889.76 ms │  1782.00 ms │ +1.06x faster │
│ QQuery 36 │   183.26 ms │   118.48 ms │ +1.55x faster │
│ QQuery 37 │    74.17 ms │    56.19 ms │ +1.32x faster │
│ QQuery 38 │   110.97 ms │    60.93 ms │ +1.82x faster │
│ QQuery 39 │   342.63 ms │   222.50 ms │ +1.54x faster │
│ QQuery 40 │    40.01 ms │    27.18 ms │ +1.47x faster │
│ QQuery 41 │    33.73 ms │    25.01 ms │ +1.35x faster │
│ QQuery 42 │    31.87 ms │    22.54 ms │ +1.41x faster │
└───────────┴─────────────┴─────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary      ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 95471.22ms │
│ Total Time (morsel5)   │ 86891.49ms │
│ Average Time (HEAD)    │  2220.26ms │
│ Average Time (morsel5) │  2020.73ms │
│ Queries Faster         │         31 │
│ Queries Slower         │          1 │
│ Queries with No Change │         11 │
│ Queries with Failure   │          0 │
└────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃   morsel5 ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 100.97 ms │ 104.06 ms │     no change │
│ QQuery 2  │  34.22 ms │  32.72 ms │     no change │
│ QQuery 3  │  40.31 ms │  40.21 ms │     no change │
│ QQuery 4  │  30.61 ms │  30.22 ms │     no change │
│ QQuery 5  │  90.88 ms │  90.13 ms │     no change │
│ QQuery 6  │  20.93 ms │  20.78 ms │     no change │
│ QQuery 7  │ 163.15 ms │ 163.15 ms │     no change │
│ QQuery 8  │  41.88 ms │  39.43 ms │ +1.06x faster │
│ QQuery 9  │ 103.74 ms │ 102.82 ms │     no change │
│ QQuery 10 │  69.44 ms │  67.03 ms │     no change │
│ QQuery 11 │  19.07 ms │  18.59 ms │     no change │
│ QQuery 12 │  52.64 ms │  51.11 ms │     no change │
│ QQuery 13 │  49.61 ms │  50.53 ms │     no change │
│ QQuery 14 │  14.81 ms │  15.36 ms │     no change │
│ QQuery 15 │  29.86 ms │  30.80 ms │     no change │
│ QQuery 16 │  27.61 ms │  30.82 ms │  1.12x slower │
│ QQuery 17 │ 140.63 ms │ 144.12 ms │     no change │
│ QQuery 18 │ 286.42 ms │ 286.41 ms │     no change │
│ QQuery 19 │  39.69 ms │  38.73 ms │     no change │
│ QQuery 20 │  56.43 ms │  57.46 ms │     no change │
│ QQuery 21 │ 184.21 ms │ 184.80 ms │     no change │
│ QQuery 22 │  22.84 ms │  22.27 ms │     no change │
└───────────┴───────────┴───────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary      ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 1619.96ms │
│ Total Time (morsel5)   │ 1621.55ms │
│ Average Time (HEAD)    │   73.63ms │
│ Average Time (morsel5) │   73.71ms │
│ Queries Faster         │         1 │
│ Queries Slower         │         1 │
│ Queries with No Change │        20 │
│ Queries with Failure   │         0 │
└────────────────────────┴───────────┘

@Dandandan
Copy link
Contributor Author

run benchmark clickbench_extended
DATAFUSION_EXECUTION_PARQUET_PUSHDOWN_FILTERS=true
DATAFUSION_EXECUTION_PARQUET_REORDER_FILTERS=true

@Dandandan
Copy link
Contributor Author

run benchmarks
DATAFUSION_EXECUTION_PARQUET_PUSHDOWN_FILTERS=true
DATAFUSION_EXECUTION_PARQUET_REORDER_FILTERS=true

@Dandandan
Copy link
Contributor Author

run benchmarks

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing morsel5 (1862d44) to e583fe9 diff using: clickbench_extended
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and morsel5
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query    ┃        HEAD ┃     morsel5 ┃       Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 0 │  2238.63 ms │  2389.83 ms │ 1.07x slower │
│ QQuery 1 │   918.45 ms │   919.31 ms │    no change │
│ QQuery 2 │  1772.08 ms │  1840.51 ms │    no change │
│ QQuery 3 │  1071.48 ms │  1029.03 ms │    no change │
│ QQuery 4 │  2232.58 ms │  2296.28 ms │    no change │
│ QQuery 5 │ 28690.62 ms │ 28661.41 ms │    no change │
│ QQuery 6 │   108.00 ms │   107.43 ms │    no change │
│ QQuery 7 │  2923.76 ms │  2852.34 ms │    no change │
└──────────┴─────────────┴─────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary      ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 39955.60ms │
│ Total Time (morsel5)   │ 40096.14ms │
│ Average Time (HEAD)    │  4994.45ms │
│ Average Time (morsel5) │  5012.02ms │
│ Queries Faster         │          0 │
│ Queries Slower         │          1 │
│ Queries with No Change │          7 │
│ Queries with Failure   │          0 │
└────────────────────────┴────────────┘

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing morsel5 (1862d44) to e583fe9 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and morsel5
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query    ┃        HEAD ┃     morsel5 ┃    Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 0 │  2342.50 ms │  2322.72 ms │ no change │
│ QQuery 1 │   920.21 ms │   943.86 ms │ no change │
│ QQuery 2 │  1831.81 ms │  1849.31 ms │ no change │
│ QQuery 3 │  1062.77 ms │  1036.56 ms │ no change │
│ QQuery 4 │  2212.12 ms │  2201.86 ms │ no change │
│ QQuery 5 │ 28379.48 ms │ 28383.58 ms │ no change │
│ QQuery 6 │  3728.30 ms │  3912.20 ms │ no change │
│ QQuery 7 │  2700.46 ms │  2669.52 ms │ no change │
└──────────┴─────────────┴─────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary      ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 43177.66ms │
│ Total Time (morsel5)   │ 43319.60ms │
│ Average Time (HEAD)    │  5397.21ms │
│ Average Time (morsel5) │  5414.95ms │
│ Queries Faster         │          0 │
│ Queries Slower         │          0 │
│ Queries with No Change │          8 │
│ Queries with Failure   │          0 │
└────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃        HEAD ┃     morsel5 ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0  │     2.62 ms │    11.44 ms │  4.37x slower │
│ QQuery 1  │    47.93 ms │    44.67 ms │ +1.07x faster │
│ QQuery 2  │   133.57 ms │   122.80 ms │ +1.09x faster │
│ QQuery 3  │   155.09 ms │   143.65 ms │ +1.08x faster │
│ QQuery 4  │  1042.20 ms │  1089.18 ms │     no change │
│ QQuery 5  │  1273.03 ms │  1188.65 ms │ +1.07x faster │
│ QQuery 6  │     6.25 ms │     6.21 ms │     no change │
│ QQuery 7  │    54.60 ms │    49.02 ms │ +1.11x faster │
│ QQuery 8  │  1410.14 ms │  1457.50 ms │     no change │
│ QQuery 9  │  1766.62 ms │  1745.13 ms │     no change │
│ QQuery 10 │   347.27 ms │   325.92 ms │ +1.07x faster │
│ QQuery 11 │   395.58 ms │   378.28 ms │     no change │
│ QQuery 12 │  1198.29 ms │  1130.61 ms │ +1.06x faster │
│ QQuery 13 │  1877.32 ms │  1742.51 ms │ +1.08x faster │
│ QQuery 14 │  1212.71 ms │  1186.90 ms │     no change │
│ QQuery 15 │  1197.14 ms │  1236.86 ms │     no change │
│ QQuery 16 │  2478.96 ms │  2541.62 ms │     no change │
│ QQuery 17 │  2465.74 ms │  2474.54 ms │     no change │
│ QQuery 18 │  5052.85 ms │  4815.42 ms │     no change │
│ QQuery 19 │   122.01 ms │   111.42 ms │ +1.10x faster │
│ QQuery 20 │  1789.29 ms │  1665.39 ms │ +1.07x faster │
│ QQuery 21 │  2105.44 ms │  2034.16 ms │     no change │
│ QQuery 22 │  3916.61 ms │  3612.53 ms │ +1.08x faster │
│ QQuery 23 │ 18880.21 ms │ 13237.75 ms │ +1.43x faster │
│ QQuery 24 │   202.65 ms │   130.46 ms │ +1.55x faster │
│ QQuery 25 │   441.51 ms │   404.88 ms │ +1.09x faster │
│ QQuery 26 │   202.96 ms │   129.35 ms │ +1.57x faster │
│ QQuery 27 │  2636.73 ms │  2433.44 ms │ +1.08x faster │
│ QQuery 28 │ 24005.36 ms │ 23425.00 ms │     no change │
│ QQuery 29 │   969.96 ms │   919.93 ms │ +1.05x faster │
│ QQuery 30 │  1273.04 ms │  1230.50 ms │     no change │
│ QQuery 31 │  1340.47 ms │  1242.34 ms │ +1.08x faster │
│ QQuery 32 │  4427.94 ms │  4348.03 ms │     no change │
│ QQuery 33 │  5342.76 ms │  5362.87 ms │     no change │
│ QQuery 34 │  5832.80 ms │  5824.83 ms │     no change │
│ QQuery 35 │  1934.89 ms │  1883.26 ms │     no change │
│ QQuery 36 │   195.74 ms │   117.90 ms │ +1.66x faster │
│ QQuery 37 │    74.51 ms │    57.77 ms │ +1.29x faster │
│ QQuery 38 │   113.29 ms │    62.82 ms │ +1.80x faster │
│ QQuery 39 │   335.21 ms │   229.02 ms │ +1.46x faster │
│ QQuery 40 │    39.39 ms │    26.96 ms │ +1.46x faster │
│ QQuery 41 │    34.15 ms │    25.12 ms │ +1.36x faster │
│ QQuery 42 │    31.18 ms │    21.99 ms │ +1.42x faster │
└───────────┴─────────────┴─────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary      ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 98366.04ms │
│ Total Time (morsel5)   │ 90228.63ms │
│ Average Time (HEAD)    │  2287.58ms │
│ Average Time (morsel5) │  2098.34ms │
│ Queries Faster         │         25 │
│ Queries Slower         │          1 │
│ Queries with No Change │         17 │
│ Queries with Failure   │          0 │
└────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃   morsel5 ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 101.70 ms │ 103.11 ms │     no change │
│ QQuery 2  │  31.89 ms │  32.38 ms │     no change │
│ QQuery 3  │  41.54 ms │  37.83 ms │ +1.10x faster │
│ QQuery 4  │  31.03 ms │  31.51 ms │     no change │
│ QQuery 5  │  93.08 ms │  91.35 ms │     no change │
│ QQuery 6  │  20.99 ms │  20.83 ms │     no change │
│ QQuery 7  │ 159.69 ms │ 170.20 ms │  1.07x slower │
│ QQuery 8  │  40.46 ms │  41.25 ms │     no change │
│ QQuery 9  │ 102.88 ms │ 115.14 ms │  1.12x slower │
│ QQuery 10 │  67.17 ms │  69.86 ms │     no change │
│ QQuery 11 │  18.42 ms │  17.57 ms │     no change │
│ QQuery 12 │  53.12 ms │  52.36 ms │     no change │
│ QQuery 13 │  49.82 ms │  49.51 ms │     no change │
│ QQuery 14 │  15.56 ms │  15.02 ms │     no change │
│ QQuery 15 │  30.54 ms │  30.22 ms │     no change │
│ QQuery 16 │  28.12 ms │  29.14 ms │     no change │
│ QQuery 17 │ 144.44 ms │ 147.83 ms │     no change │
│ QQuery 18 │ 291.30 ms │ 297.30 ms │     no change │
│ QQuery 19 │  40.55 ms │  40.52 ms │     no change │
│ QQuery 20 │  56.02 ms │  56.97 ms │     no change │
│ QQuery 21 │ 189.39 ms │ 198.22 ms │     no change │
│ QQuery 22 │  23.01 ms │  22.81 ms │     no change │
└───────────┴───────────┴───────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary      ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 1630.70ms │
│ Total Time (morsel5)   │ 1670.94ms │
│ Average Time (HEAD)    │   74.12ms │
│ Average Time (morsel5) │   75.95ms │
│ Queries Faster         │         1 │
│ Queries Slower         │         2 │
│ Queries with No Change │        19 │
│ Queries with Failure   │         0 │
└────────────────────────┴───────────┘

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing morsel5 (1862d44) to e583fe9 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and morsel5
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query    ┃        HEAD ┃     morsel5 ┃    Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 0 │  2316.91 ms │  2407.26 ms │ no change │
│ QQuery 1 │   909.00 ms │   917.96 ms │ no change │
│ QQuery 2 │  1807.44 ms │  1837.67 ms │ no change │
│ QQuery 3 │  1012.60 ms │  1038.75 ms │ no change │
│ QQuery 4 │  2267.37 ms │  2252.62 ms │ no change │
│ QQuery 5 │ 28211.71 ms │ 28409.46 ms │ no change │
│ QQuery 6 │   112.64 ms │   110.00 ms │ no change │
│ QQuery 7 │  2838.51 ms │  2973.47 ms │ no change │
└──────────┴─────────────┴─────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary      ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 39476.18ms │
│ Total Time (morsel5)   │ 39947.20ms │
│ Average Time (HEAD)    │  4934.52ms │
│ Average Time (morsel5) │  4993.40ms │
│ Queries Faster         │          0 │
│ Queries Slower         │          0 │
│ Queries with No Change │          8 │
│ Queries with Failure   │          0 │
└────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃        HEAD ┃     morsel5 ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0  │     2.68 ms │    11.24 ms │  4.19x slower │
│ QQuery 1  │    53.16 ms │    53.58 ms │     no change │
│ QQuery 2  │   133.78 ms │   121.24 ms │ +1.10x faster │
│ QQuery 3  │   153.84 ms │   142.44 ms │ +1.08x faster │
│ QQuery 4  │  1044.29 ms │  1030.36 ms │     no change │
│ QQuery 5  │  1272.61 ms │  1176.27 ms │ +1.08x faster │
│ QQuery 6  │    17.19 ms │    12.05 ms │ +1.43x faster │
│ QQuery 7  │    66.50 ms │    58.14 ms │ +1.14x faster │
│ QQuery 8  │  1404.27 ms │  1360.54 ms │     no change │
│ QQuery 9  │  1799.01 ms │  1610.34 ms │ +1.12x faster │
│ QQuery 10 │   480.62 ms │   444.50 ms │ +1.08x faster │
│ QQuery 11 │   522.57 ms │   485.72 ms │ +1.08x faster │
│ QQuery 12 │  1399.34 ms │  1293.67 ms │ +1.08x faster │
│ QQuery 13 │  2050.85 ms │  1826.94 ms │ +1.12x faster │
│ QQuery 14 │  1392.18 ms │  1298.55 ms │ +1.07x faster │
│ QQuery 15 │  1181.69 ms │  1161.85 ms │     no change │
│ QQuery 16 │  2489.82 ms │  2456.95 ms │     no change │
│ QQuery 17 │  2450.57 ms │  2437.00 ms │     no change │
│ QQuery 18 │  5236.54 ms │  5056.56 ms │     no change │
│ QQuery 19 │   139.16 ms │   127.08 ms │ +1.10x faster │
│ QQuery 20 │  1803.24 ms │  1915.84 ms │  1.06x slower │
│ QQuery 21 │  2216.71 ms │  2135.25 ms │     no change │
│ QQuery 22 │  3894.93 ms │  3527.12 ms │ +1.10x faster │
│ QQuery 23 │  1047.59 ms │   307.55 ms │ +3.41x faster │
│ QQuery 24 │   242.09 ms │   128.25 ms │ +1.89x faster │
│ QQuery 25 │   627.78 ms │   561.28 ms │ +1.12x faster │
│ QQuery 26 │   324.04 ms │   193.29 ms │ +1.68x faster │
│ QQuery 27 │  2862.11 ms │  2578.58 ms │ +1.11x faster │
│ QQuery 28 │ 24424.20 ms │ 24030.07 ms │     no change │
│ QQuery 29 │   955.15 ms │   936.50 ms │     no change │
│ QQuery 30 │  1270.65 ms │  1388.39 ms │  1.09x slower │
│ QQuery 31 │  1305.79 ms │  1443.99 ms │  1.11x slower │
│ QQuery 32 │  4589.67 ms │  3945.88 ms │ +1.16x faster │
│ QQuery 33 │  5319.50 ms │  5235.44 ms │     no change │
│ QQuery 34 │  5674.66 ms │  5472.03 ms │     no change │
│ QQuery 35 │  1886.44 ms │  1775.94 ms │ +1.06x faster │
│ QQuery 36 │   176.52 ms │   127.57 ms │ +1.38x faster │
│ QQuery 37 │    89.77 ms │    71.62 ms │ +1.25x faster │
│ QQuery 38 │    90.25 ms │    64.15 ms │ +1.41x faster │
│ QQuery 39 │   292.93 ms │   209.28 ms │ +1.40x faster │
│ QQuery 40 │    57.30 ms │    40.08 ms │ +1.43x faster │
│ QQuery 41 │    49.74 ms │    37.03 ms │ +1.34x faster │
│ QQuery 42 │    38.28 ms │    28.40 ms │ +1.35x faster │
└───────────┴─────────────┴─────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary      ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 82530.00ms │
│ Total Time (morsel5)   │ 78318.54ms │
│ Average Time (HEAD)    │  1919.30ms │
│ Average Time (morsel5) │  1821.36ms │
│ Queries Faster         │         27 │
│ Queries Slower         │          4 │
│ Queries with No Change │         12 │
│ Queries with Failure   │          0 │
└────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃   morsel5 ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 101.44 ms │ 103.00 ms │     no change │
│ QQuery 2  │  31.71 ms │  33.45 ms │  1.06x slower │
│ QQuery 3  │  39.02 ms │  36.37 ms │ +1.07x faster │
│ QQuery 4  │  30.98 ms │  31.95 ms │     no change │
│ QQuery 5  │  91.89 ms │  91.48 ms │     no change │
│ QQuery 6  │  20.93 ms │  20.93 ms │     no change │
│ QQuery 7  │ 164.41 ms │ 169.34 ms │     no change │
│ QQuery 8  │  40.69 ms │  42.51 ms │     no change │
│ QQuery 9  │ 103.32 ms │ 102.54 ms │     no change │
│ QQuery 10 │  68.08 ms │  69.26 ms │     no change │
│ QQuery 11 │  18.27 ms │  18.98 ms │     no change │
│ QQuery 12 │  52.68 ms │  51.81 ms │     no change │
│ QQuery 13 │  49.19 ms │  48.35 ms │     no change │
│ QQuery 14 │  15.45 ms │  14.95 ms │     no change │
│ QQuery 15 │  30.69 ms │  30.39 ms │     no change │
│ QQuery 16 │  28.73 ms │  28.50 ms │     no change │
│ QQuery 17 │ 145.66 ms │ 150.88 ms │     no change │
│ QQuery 18 │ 292.55 ms │ 287.14 ms │     no change │
│ QQuery 19 │  39.50 ms │  39.86 ms │     no change │
│ QQuery 20 │  56.66 ms │  56.01 ms │     no change │
│ QQuery 21 │ 190.29 ms │ 198.86 ms │     no change │
│ QQuery 22 │  22.88 ms │  23.44 ms │     no change │
└───────────┴───────────┴───────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary      ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)      │ 1635.01ms │
│ Total Time (morsel5)   │ 1650.01ms │
│ Average Time (HEAD)    │   74.32ms │
│ Average Time (morsel5) │   75.00ms │
│ Queries Faster         │         1 │
│ Queries Slower         │         1 │
│ Queries with No Change │        20 │
│ Queries with Failure   │         0 │
└────────────────────────┴───────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate documentation Improvements or additions to documentation optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants