Decode Hive partition values in listing tables#23226
Open
Kevin-Li-2025 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kevin-Li-2025 <2242139@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Hive-style partition values can contain percent-encoded characters in object-store paths, such as
%2Ffor/or%20for a space.parse_partitions_for_pathcurrently returns those encoded bytes literally, so listing tables exposefoo%2Fbarinstead offoo/bar.What changes are included in this PR?
parse_partitions_for_path.Cow<str>from the parser so unchanged values keep the borrowed fast path and decoded values can be owned only when needed.PartitionedFileconversion tests for decoded partition values.Are these changes tested?
cargo fmt --all --checkcargo test -p datafusion-catalog-listing