refactor: make_map_batch array handling#23228
Open
nathanb9 wants to merge 1 commit into
Open
Conversation
nathanb9
changed the title
make_map_batch array handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
make_map_batchto avoid wrapping expanded arrays back inColumnarValue#22833.Rationale for this change
Simplify make_map_batch array handling after scalar expansion.
What changes are included in this PR?
Pass extracted ArrayRefs through validation and map construction.
Are these changes tested?
Ran
cargo fmt --all,cargo test -p datafusion-functions-nested map, andcargo clippy --all-targets --all-features -- -D warnings.Are there any user-facing changes?
No.