fix(sonarqube): correct aggregate coverage formula in Grafana dashboards#8997
Open
bramhanandlingala wants to merge 1 commit into
Open
fix(sonarqube): correct aggregate coverage formula in Grafana dashboards#8997bramhanandlingala wants to merge 1 commit into
bramhanandlingala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the SonarQube Grafana dashboard "Test" panel, which showed a
coverage percentage that didn't match SonarQube's own reported
coverage for the project.
Root cause
The panel recalculated coverage from raw line counts
(
lines_to_cover/uncovered_lines), which only accounts for linecoverage and ignores condition coverage. SonarQube's real
coveragemetric is already collected correctly per file in
cq_file_metrics.coverage— the dashboard just wasn't using it.Fix
Changed the panel query to use a weighted average of the existing
coveragecolumn (weighted bylines_to_cover) instead ofrecomputing it from scratch.9
Fixes #8973