[fix](doc) dev: un-glue SET lc_time_names from comment line in MONTHNAME example#3863
Merged
morningman merged 1 commit intoJun 2, 2026
Merged
Conversation
…AME example
The EN dev `monthname.md` localization example had the explanatory comment and
the SET statement on a single `--` comment line:
---Control the output language by setting `lc_time_names`SET lc_time_names='zh_CN';
SELECT MONTHNAME('2023-07-13 22:28:18') AS result;
| 七月 |
Because the whole line is a SQL line-comment, `SET lc_time_names='zh_CN';` is
commented out. A reader copy-pasting the block runs the SELECT in the default
`en_US` session and gets `July`, not the documented `七月` — the localization
example is inert/misleading. Fix: put SET on its own line (matching the `-- `
comment style used elsewhere in the same block).
The documented output values are all correct; only the formatting was broken.
The ZH page (`i18n/.../current/.../monthname.md`) and the v4.x EN page already
have SET on its own line and are unaffected, so this is a dev-EN-only fix.
Verified end-to-end on a live master daily build (doris-0.0.0-2e72603618c):
SELECT MONTHNAME('2023-07-13 22:28:18'); -> July
SET lc_time_names='zh_CN';
SELECT MONTHNAME('2023-07-13 22:28:18'); -> 七月
SET lc_time_names='AR_sa';
SELECT MONTHNAME('2023-07-13 22:28:18'); -> يوليو
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EN dev
monthname.mdlocalization example put the explanatory comment and theSETstatement on a single--comment line:Because the entire line is a SQL line-comment,
SET lc_time_names='zh_CN';is commented out. A reader copy-pasting the block runs theSELECTin the defaulten_USsession and getsJuly, not the documented七月— so the localization example is inert and misleading.Fix: move
SETonto its own line (matching the--comment style used by the other comments in the same block). The documented output values are all correct; only the formatting was broken.Scope: dev EN only. The ZH page (
i18n/zh-CN/.../current/.../monthname.md) and the v4.x EN page already haveSETon its own line, so they are unaffected — no backport needed.Verification — run end-to-end on a live master daily build (
doris-0.0.0-2e72603618c):All three outputs match the documented expected values.
🤖 Generated with Claude Code