-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](Iot&auto partition) Add fix for the auto-partition issue during insert overwrite #59462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 36004 ms |
TPC-DS: Total hot run time: 174982 ms |
ClickBench: Total hot run time: 27.84 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 32240 ms |
TPC-DS: Total hot run time: 173524 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 31816 ms |
TPC-DS: Total hot run time: 173884 ms |
ClickBench: Total hot run time: 27.95 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 32159 ms |
TPC-DS: Total hot run time: 174004 ms |
ClickBench: Total hot run time: 26.86 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…issue during insert overwrite #59462 (#60081) Cherry-picked from #59462 Co-authored-by: Refrain <[email protected]>
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx #57198
Problem Summary:
In PR #57198, our fix only ensures the idempotence of the createPartition RPC within a single load transaction, but overlooked the case of insert overwrite using replacePartition.
What's more, we add some case in this pr.
Regarding the issue of tablet rebalance occurring during auto-partitioned data loading, you can refer to the details in PR #57198: #57198
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)