Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Dec 30, 2025

What problem does this PR solve?

The function update_hash_with_value and update_hashes_with_value are used by some EngineChecksumTask::_compute_checksum().

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg
Copy link
Member Author

mrhhsg commented Dec 30, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34593 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 92c50144c67aff314a492afa33493afefb7e8305, data reload: false

------ Round 1 ----------------------------------
q1	17643	4190	4044	4044
q2	2070	362	230	230
q3	10193	1306	754	754
q4	10224	943	344	344
q5	7553	2135	1975	1975
q6	196	172	138	138
q7	945	814	670	670
q8	9292	1476	1210	1210
q9	6964	5224	5240	5224
q10	6820	1886	1443	1443
q11	525	327	281	281
q12	702	767	612	612
q13	17791	3842	3067	3067
q14	291	295	271	271
q15	598	515	533	515
q16	686	668	643	643
q17	704	774	629	629
q18	7519	7325	7218	7218
q19	1104	992	617	617
q20	404	370	259	259
q21	4292	3948	3445	3445
q22	1106	1043	1004	1004
Total cold run time: 107622 ms
Total hot run time: 34593 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4109	4045	4077	4045
q2	320	397	323	323
q3	2065	2599	2250	2250
q4	1280	1795	1311	1311
q5	4127	4405	4808	4405
q6	214	171	132	132
q7	2030	1951	1845	1845
q8	2546	2373	2363	2363
q9	7272	7153	7134	7134
q10	2628	2777	2386	2386
q11	554	467	444	444
q12	729	764	615	615
q13	3673	4052	3338	3338
q14	293	297	298	297
q15	540	500	518	500
q16	640	722	642	642
q17	1140	1305	1403	1305
q18	8244	7804	7599	7599
q19	862	864	903	864
q20	1967	2065	1868	1868
q21	4761	4321	4122	4122
q22	1092	1033	1008	1008
Total cold run time: 51086 ms
Total hot run time: 48796 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174784 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 92c50144c67aff314a492afa33493afefb7e8305, data reload: false

query5	4842	587	437	437
query6	355	237	226	226
query7	4223	464	274	274
query8	334	255	236	236
query9	8759	2608	2629	2608
query10	574	385	321	321
query11	15071	15141	14811	14811
query12	186	115	114	114
query13	1263	497	388	388
query14	6425	2942	2723	2723
query14_1	2681	2616	2612	2612
query15	202	192	176	176
query16	994	495	454	454
query17	1077	699	600	600
query18	2566	441	354	354
query19	230	227	202	202
query20	128	120	118	118
query21	215	142	116	116
query22	4006	4197	3853	3853
query23	16183	15492	15330	15330
query23_1	15374	15422	15460	15422
query24	7425	1600	1198	1198
query24_1	1210	1227	1221	1221
query25	569	480	438	438
query26	1240	263	155	155
query27	2773	442	292	292
query28	4557	2198	2187	2187
query29	768	517	432	432
query30	314	239	209	209
query31	774	618	544	544
query32	81	69	70	69
query33	541	343	280	280
query34	914	867	535	535
query35	736	787	708	708
query36	832	895	824	824
query37	134	103	80	80
query38	2691	2688	2692	2688
query39	773	759	728	728
query39_1	714	713	704	704
query40	219	130	116	116
query41	69	63	65	63
query42	105	102	98	98
query43	422	459	422	422
query44	1327	763	755	755
query45	185	186	178	178
query46	881	965	610	610
query47	1430	1442	1360	1360
query48	314	325	240	240
query49	597	448	326	326
query50	645	281	216	216
query51	3796	3779	3743	3743
query52	103	113	92	92
query53	292	318	270	270
query54	276	262	251	251
query55	75	75	70	70
query56	280	284	313	284
query57	988	1015	925	925
query58	274	256	245	245
query59	2176	2212	2170	2170
query60	320	309	295	295
query61	158	157	156	156
query62	393	367	303	303
query63	308	267	270	267
query64	4992	1315	981	981
query65	3810	3743	3846	3743
query66	1410	424	327	327
query67	15156	15543	15398	15398
query68	4720	1017	738	738
query69	525	350	303	303
query70	1067	943	939	939
query71	368	291	272	272
query72	6102	4736	5032	4736
query73	692	577	309	309
query74	8767	8736	8649	8649
query75	2905	2906	2505	2505
query76	3900	1103	654	654
query77	517	369	285	285
query78	9613	9850	9124	9124
query79	1580	866	598	598
query80	672	574	496	496
query81	523	268	229	229
query82	415	141	111	111
query83	264	260	246	246
query84	262	120	124	120
query85	918	523	465	465
query86	399	318	297	297
query87	2864	2915	2735	2735
query88	3298	2290	2290	2290
query89	398	342	327	327
query90	1986	153	149	149
query91	171	166	143	143
query92	70	70	62	62
query93	1183	918	564	564
query94	581	331	284	284
query95	579	330	358	330
query96	592	462	206	206
query97	2301	2400	2293	2293
query98	243	200	200	200
query99	572	560	479	479
Total cold run time: 252034 ms
Total hot run time: 174784 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.97 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 92c50144c67aff314a492afa33493afefb7e8305, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.05	0.05
query3	0.26	0.09	0.08
query4	1.60	0.11	0.11
query5	0.28	0.26	0.27
query6	1.15	0.66	0.66
query7	0.03	0.03	0.02
query8	0.06	0.04	0.04
query9	0.58	0.51	0.51
query10	0.55	0.56	0.54
query11	0.16	0.11	0.11
query12	0.16	0.13	0.14
query13	0.62	0.59	0.60
query14	0.98	0.99	0.97
query15	0.82	0.80	0.81
query16	0.41	0.39	0.42
query17	1.06	1.07	1.02
query18	0.23	0.22	0.21
query19	1.91	1.90	1.82
query20	0.02	0.01	0.02
query21	15.47	0.33	0.15
query22	4.82	0.05	0.05
query23	16.10	0.29	0.10
query24	0.94	0.51	0.24
query25	0.08	0.11	0.05
query26	0.15	0.14	0.14
query27	0.08	0.05	0.06
query28	4.12	1.07	0.88
query29	12.62	3.91	3.17
query30	0.28	0.13	0.13
query31	2.81	0.62	0.39
query32	3.24	0.56	0.48
query33	3.00	3.04	3.06
query34	16.63	5.12	4.46
query35	4.47	4.46	4.46
query36	0.67	0.51	0.48
query37	0.10	0.06	0.06
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.12
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.05 s
Total hot run time: 26.97 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 30, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.41% (18966/35510)
Line Coverage 39.28% (176004/448065)
Region Coverage 33.81% (136065/402430)
Branch Coverage 34.77% (58810/169138)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.22% (25070/34715)
Line Coverage 58.96% (263480/446873)
Region Coverage 53.75% (218528/406593)
Branch Coverage 55.34% (93915/169700)

@yiguolei yiguolei merged commit 53f8002 into apache:master Dec 31, 2025
27 of 29 checks passed
yiguolei pushed a commit that referenced this pull request Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants