[enhance](auth) introduction of ldaps support via configuration property by iaorekhov-1980 · Pull Request #60275 · apache/doris

iaorekhov-1980 · 2026-01-27T09:15:29Z

What problem does this PR solve?

This PR adds new configuration property ldap_use_ssl to enable usage of LDAPS to establish connection to LDAP instance.
If ldap_use_ssl in ldap.conf is specified as true - LDAPS is used to create connection string.
If ldap_use_ssl in ldap.conf is not specified or specified as false - LDAP is used to create connection string as now.

Could you please include this PR into 4.x and 3.1.x branches, please!

Issue Number: close #60236

Related PR: #xxx

Problem Summary:

Currently it is not possible to use LDAPS to create connection to secured LDAP instances.
New configuration property allows to connect to such instances, but default behavior still relies on LDAP as is.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.

ldap.conf and LdapConfig.java - new configuration ldap_use_ssl property added and static method to get actual URL connection string (this method was mostly introduced to support unit testing)
LdapClient.java - replaced explicit generation of URL connection string with call to new method in LDAP config
LdapClientTest.java - introduced new test method to validate existing behavior (without specified ldap_use_ssl property) and new one (with ldap_use_ssl property specified to true) to generate correct connection strings.

Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2026-01-27T09:15:41Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

iaorekhov-1980 · 2026-01-27T09:18:52Z

run buildall

iaorekhov-1980 · 2026-01-27T09:30:55Z

run buildall

iaorekhov-1980 · 2026-01-27T10:25:53Z

run feut

iaorekhov-1980 · 2026-01-27T10:45:32Z

run feut

iaorekhov-1980 · 2026-01-27T11:26:17Z

run feut

iaorekhov-1980 · 2026-01-27T13:06:04Z

run feut

iaorekhov-1980 · 2026-01-27T13:52:54Z

run feut

iaorekhov-1980 · 2026-01-27T14:14:18Z

run feut

hello-stephen · 2026-01-27T15:44:09Z

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

iaorekhov-1980 · 2026-01-27T15:45:04Z

run buildall

doris-robot · 2026-01-27T16:17:53Z

TPC-H: Total hot run time: 33048 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3974e9f14b99a306b890e8c7962e57d2e06752c9, data reload: false

------ Round 1 ----------------------------------
q1	17633	5234	5034	5034
q2	2023	332	196	196
q3	10203	1317	753	753
q4	10222	855	320	320
q5	7515	2162	1920	1920
q6	197	179	149	149
q7	900	765	594	594
q8	9257	1395	1180	1180
q9	5206	4843	4858	4843
q10	6741	1945	1564	1564
q11	527	285	271	271
q12	337	382	231	231
q13	17770	4065	3242	3242
q14	231	237	227	227
q15	878	834	807	807
q16	682	728	632	632
q17	639	770	482	482
q18	6898	6538	7539	6538
q19	1137	1026	676	676
q20	433	382	238	238
q21	2842	2473	2057	2057
q22	1128	1094	1146	1094
Total cold run time: 103399 ms
Total hot run time: 33048 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5528	5484	5452	5452
q2	262	340	279	279
q3	2351	2900	2537	2537
q4	1451	1918	1468	1468
q5	5117	4452	4656	4452
q6	233	189	137	137
q7	2032	1943	1855	1855
q8	2656	2493	2360	2360
q9	7521	7571	7353	7353
q10	2881	3178	2656	2656
q11	549	477	453	453
q12	680	762	635	635
q13	3875	4192	3188	3188
q14	273	306	262	262
q15	843	789	788	788
q16	624	701	630	630
q17	1085	1273	1298	1273
q18	7791	7415	7336	7336
q19	825	790	807	790
q20	1948	2053	1908	1908
q21	4486	4160	4055	4055
q22	1046	1014	962	962
Total cold run time: 54057 ms
Total hot run time: 50829 ms

doris-robot · 2026-01-27T16:34:42Z

ClickBench: Total hot run time: 28.47 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3974e9f14b99a306b890e8c7962e57d2e06752c9, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.08	0.08
query4	1.61	0.11	0.11
query5	0.27	0.25	0.25
query6	1.16	0.69	0.67
query7	0.03	0.03	0.02
query8	0.05	0.03	0.03
query9	0.56	0.50	0.50
query10	0.56	0.54	0.54
query11	0.13	0.09	0.10
query12	0.14	0.10	0.10
query13	0.63	0.61	0.61
query14	1.05	1.07	1.06
query15	0.87	0.87	0.86
query16	0.41	0.40	0.41
query17	1.09	1.14	1.13
query18	0.23	0.21	0.22
query19	2.07	1.95	2.02
query20	0.02	0.02	0.02
query21	15.41	0.25	0.15
query22	5.31	0.06	0.05
query23	16.13	0.27	0.10
query24	1.52	0.34	0.39
query25	0.10	0.06	0.06
query26	0.15	0.14	0.14
query27	0.07	0.05	0.06
query28	3.55	1.14	0.96
query29	12.56	3.96	3.19
query30	0.28	0.13	0.15
query31	2.82	0.62	0.40
query32	3.23	0.59	0.49
query33	3.26	3.33	3.25
query34	16.36	5.40	4.78
query35	4.80	4.78	4.80
query36	0.64	0.50	0.49
query37	0.12	0.07	0.07
query38	0.08	0.04	0.04
query39	0.04	0.02	0.02
query40	0.18	0.16	0.16
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.03
Total cold run time: 98.07 s
Total hot run time: 28.47 s

hello-stephen · 2026-01-27T18:46:58Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

iaorekhov-1980 · 2026-01-27T18:59:37Z

run buildall

iaorekhov-1980 · 2026-01-27T19:11:57Z

run p0

doris-robot · 2026-01-27T19:37:12Z

TPC-H: Total hot run time: 32785 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3974e9f14b99a306b890e8c7962e57d2e06752c9, data reload: false

------ Round 1 ----------------------------------
q1	17639	5218	5047	5047
q2	2046	306	189	189
q3	10191	1357	761	761
q4	10225	907	341	341
q5	7561	2164	1959	1959
q6	197	181	150	150
q7	899	742	602	602
q8	9276	1494	1178	1178
q9	5212	4804	4832	4804
q10	6777	1966	1579	1579
q11	526	308	274	274
q12	341	381	229	229
q13	17766	4063	3289	3289
q14	265	237	212	212
q15	899	822	817	817
q16	686	677	608	608
q17	639	848	419	419
q18	6725	6593	6578	6578
q19	1284	980	614	614
q20	414	347	232	232
q21	2745	2123	1932	1932
q22	1024	1058	971	971
Total cold run time: 103337 ms
Total hot run time: 32785 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5259	5260	5210	5210
q2	256	327	262	262
q3	2259	2729	2312	2312
q4	1413	1827	1348	1348
q5	4240	4190	4632	4190
q6	248	201	156	156
q7	2203	2016	1882	1882
q8	2691	2415	2416	2415
q9	7570	7563	7505	7505
q10	2884	2976	2555	2555
q11	532	473	467	467
q12	698	746	647	647
q13	4224	4256	3637	3637
q14	315	318	294	294
q15	915	854	825	825
q16	673	705	675	675
q17	1198	1385	1466	1385
q18	8146	7875	7875	7875
q19	868	865	859	859
q20	2106	2240	1939	1939
q21	4571	4262	4103	4103
q22	1082	1015	986	986
Total cold run time: 54351 ms
Total hot run time: 51527 ms

doris-robot · 2026-01-27T19:53:59Z

ClickBench: Total hot run time: 28.41 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3974e9f14b99a306b890e8c7962e57d2e06752c9, data reload: false

query1	0.05	0.06	0.05
query2	0.10	0.04	0.05
query3	0.26	0.08	0.09
query4	1.60	0.12	0.11
query5	0.28	0.25	0.25
query6	1.16	0.67	0.67
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.56	0.50	0.50
query10	0.54	0.55	0.54
query11	0.15	0.09	0.10
query12	0.13	0.10	0.10
query13	0.62	0.62	0.61
query14	1.08	1.05	1.07
query15	0.88	0.86	0.87
query16	0.42	0.38	0.40
query17	1.08	1.14	1.14
query18	0.22	0.20	0.20
query19	2.10	1.99	2.05
query20	0.02	0.01	0.02
query21	15.41	0.25	0.14
query22	5.52	0.05	0.05
query23	16.27	0.28	0.10
query24	1.42	1.00	0.41
query25	0.11	0.06	0.09
query26	0.14	0.13	0.13
query27	0.11	0.06	0.04
query28	4.40	1.14	0.97
query29	12.54	3.90	3.17
query30	0.26	0.13	0.12
query31	2.82	0.64	0.41
query32	3.24	0.59	0.50
query33	3.34	3.23	3.35
query34	16.21	5.37	4.71
query35	4.76	4.76	4.78
query36	0.65	0.51	0.50
query37	0.10	0.06	0.06
query38	0.07	0.05	0.04
query39	0.05	0.04	0.03
query40	0.20	0.16	0.15
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 99.14 s
Total hot run time: 28.41 s

hello-stephen · 2026-01-27T21:38:43Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-01-27T21:40:51Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

iaorekhov-1980 · 2026-01-27T21:43:35Z

run cloud_p0

hello-stephen · 2026-01-27T21:52:51Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

iaorekhov-1980 · 2026-01-27T21:53:51Z

run p0

hello-stephen · 2026-01-27T23:37:16Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

github-actions · 2026-03-12T02:44:18Z

PR approved by anyone and no changes requested.

morningman · 2026-03-12T17:38:08Z

/review

github-actions · 2026-03-12T17:44:20Z

Code Review Summary

PR: enhance introduction of ldaps support via configuration property

Overall Assessment

This is a clean, well-structured PR that adds LDAPS support through a new ldap_use_ssl configuration property. No blocking issues found.

Review Checklist

Correctness: Pass. The URL construction logic correctly switches between ldap:// and ldaps:// based on the flag. Both LDAP connection creation paths in LdapClient.java (setLdapTemplateNoPool and setLdapTemplatePool) are updated to use the centralized LdapConfig.getConnectionURL() method. No hardcoded ldap:// strings remain in production code.

Backward Compatibility: Pass. The ldap_use_ssl flag defaults to false, preserving existing behavior. No behavioral changes occur unless the user explicitly sets ldap_use_ssl = true.

Test Coverage: Pass. The new testSecuredProtocolIsUsed test verifies both the default (ldap://) and SSL (ldaps://) URL generation. Proper cleanup in @After/tearDown() ensures test isolation. Existing tests are not impacted.

Design: Pass. The centralized getConnectionURL() method in LdapConfig is the single source of truth for URL construction - clean and maintainable.

Configuration: Pass. The config property is properly commented in ldap.conf with a helpful note about port 636 for LDAPS.

Observations (Non-blocking)

SSL trust store configuration: When ldap_use_ssl=true, the LDAPS connection will rely entirely on the JVM's default trust store (cacerts). Users connecting to LDAP servers with self-signed or non-publicly-trusted certificates would need to manually import the certificate via JVM arguments (-Djavax.net.ssl.trustStore). This is standard behavior for Spring LDAP and acceptable for an initial implementation, but it may be worth documenting this requirement (e.g., in the conf comment or user-facing docs) so users understand how to configure trust for non-public CAs.
Minor style note: The outer parentheses in return ((LdapConfig.ldap_use_ssl ? "ldaps" : "ldap") + "://" + hostPortInAccessibleFormat); at LdapConfig.java:176 are redundant - return (LdapConfig.ldap_use_ssl ? "ldaps" : "ldap") + "://" + hostPortInAccessibleFormat; would be sufficient. Very minor.

No issues requiring changes. The PR is ready for merge from a code quality perspective.

morningman

LGTM

morningman · 2026-03-13T05:53:54Z

@iaorekhov-1980 could please rebase and trigger test again?

…ting

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

iaorekhov-1980 · 2026-03-13T08:04:16Z

run feut

iaorekhov-1980 · 2026-03-13T09:32:19Z

run buildall

doris-robot · 2026-03-13T10:05:57Z

TPC-H: Total hot run time: 26827 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c4c0070b8e6e9a47d2e5fae6f20d4ff0f5d720d9, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17649	4431	4262	4262
q2	q3	10655	769	510	510
q4	4679	348	255	255
q5	7569	1191	1020	1020
q6	177	175	151	151
q7	772	844	666	666
q8	9295	1467	1304	1304
q9	4872	4734	4682	4682
q10	6286	1909	1660	1660
q11	468	267	239	239
q12	737	571	468	468
q13	18049	2911	2186	2186
q14	227	227	224	224
q15	q16	762	741	665	665
q17	730	841	430	430
q18	5921	5435	5293	5293
q19	1127	974	617	617
q20	538	483	406	406
q21	4537	1884	1494	1494
q22	366	516	295	295
Total cold run time: 95416 ms
Total hot run time: 26827 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4741	4602	4664	4602
q2	q3	3868	4349	3860	3860
q4	918	1220	830	830
q5	4057	4434	4307	4307
q6	188	178	150	150
q7	1750	1642	1542	1542
q8	2484	2716	2528	2528
q9	7610	7376	7342	7342
q10	3755	4032	3735	3735
q11	502	430	412	412
q12	484	580	446	446
q13	2808	3155	2404	2404
q14	280	300	263	263
q15	q16	729	756	712	712
q17	1130	1345	1353	1345
q18	7124	6951	6853	6853
q19	1027	922	947	922
q20	2077	2169	1988	1988
q21	3961	3509	3503	3503
q22	471	427	391	391
Total cold run time: 49964 ms
Total hot run time: 48135 ms

doris-robot · 2026-03-13T10:16:48Z

TPC-DS: Total hot run time: 168894 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c4c0070b8e6e9a47d2e5fae6f20d4ff0f5d720d9, data reload: false

query5	4325	647	528	528
query6	321	230	207	207
query7	4208	460	275	275
query8	333	261	231	231
query9	8731	2755	2759	2755
query10	536	402	345	345
query11	6966	5137	4905	4905
query12	194	129	127	127
query13	1265	456	366	366
query14	5732	3759	3579	3579
query14_1	2884	2862	2849	2849
query15	207	193	175	175
query16	974	473	436	436
query17	875	726	646	646
query18	2471	432	341	341
query19	207	203	173	173
query20	129	124	125	124
query21	211	129	116	116
query22	13266	14140	14691	14140
query23	15995	15733	15589	15589
query23_1	15822	15496	15735	15496
query24	7343	1610	1227	1227
query24_1	1252	1270	1264	1264
query25	550	456	401	401
query26	1234	255	150	150
query27	2790	484	298	298
query28	4491	1857	1869	1857
query29	852	569	478	478
query30	296	231	190	190
query31	989	937	876	876
query32	77	72	73	72
query33	506	338	288	288
query34	886	900	550	550
query35	639	684	613	613
query36	1061	1115	943	943
query37	134	96	82	82
query38	2954	2907	2908	2907
query39	855	845	805	805
query39_1	795	782	802	782
query40	234	153	136	136
query41	64	59	57	57
query42	261	262	254	254
query43	246	262	224	224
query44	
query45	205	190	190	190
query46	871	998	625	625
query47	2103	2121	2048	2048
query48	304	327	226	226
query49	625	454	381	381
query50	672	283	216	216
query51	4021	4110	4053	4053
query52	259	266	254	254
query53	292	338	299	299
query54	316	283	283	283
query55	99	89	84	84
query56	341	327	348	327
query57	1936	1703	1779	1703
query58	293	283	276	276
query59	2846	3042	2795	2795
query60	352	346	319	319
query61	151	151	142	142
query62	641	601	537	537
query63	315	290	277	277
query64	5141	1293	1019	1019
query65	
query66	1455	470	381	381
query67	24601	24590	24114	24114
query68	
query69	400	330	299	299
query70	948	971	961	961
query71	339	314	312	312
query72	2731	2817	2500	2500
query73	552	576	328	328
query74	9613	9575	9392	9392
query75	2843	2794	2468	2468
query76	2293	1033	687	687
query77	377	395	325	325
query78	10973	11056	10473	10473
query79	3140	784	587	587
query80	1772	641	591	591
query81	580	263	229	229
query82	1001	153	123	123
query83	351	270	258	258
query84	309	137	112	112
query85	1008	489	438	438
query86	511	326	320	320
query87	3144	3160	3002	3002
query88	3915	2677	2671	2671
query89	427	371	346	346
query90	2120	188	187	187
query91	163	165	137	137
query92	91	75	76	75
query93	2846	867	494	494
query94	639	294	283	283
query95	601	406	311	311
query96	634	510	231	231
query97	2448	2480	2399	2399
query98	243	221	223	221
query99	993	997	899	899
Total cold run time: 254464 ms
Total hot run time: 168894 ms

hello-stephen · 2026-03-13T10:47:00Z

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

iaorekhov-1980 · 2026-03-13T12:25:07Z

Hello, @morningman
I've re-based the PR to the actual master and re-launched the tests.
Everything is fine except check_coverage_fe, but as I can see - this test failed today at almost every attempt.
But if needed - I can re-launch entire suite.
Please also take care of PR apache/doris-website#3351 - because it contains docs for this feature.

iaorekhov-1980 · 2026-03-16T07:27:01Z

run buildall

hello-stephen · 2026-03-16T08:44:23Z

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

doris-robot · 2026-03-16T08:59:24Z

TPC-H: Total hot run time: 26837 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c4c0070b8e6e9a47d2e5fae6f20d4ff0f5d720d9, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17647	4512	4263	4263
q2	q3	10638	792	532	532
q4	4703	353	251	251
q5	7778	1222	984	984
q6	179	170	147	147
q7	798	857	682	682
q8	10109	1483	1311	1311
q9	6093	4746	4678	4678
q10	6294	1943	1672	1672
q11	499	255	254	254
q12	730	590	469	469
q13	18075	2997	2181	2181
q14	221	236	206	206
q15	q16	732	751	665	665
q17	720	871	404	404
q18	6359	5415	5358	5358
q19	1110	963	635	635
q20	524	505	368	368
q21	4457	2187	1504	1504
q22	406	330	273	273
Total cold run time: 98072 ms
Total hot run time: 26837 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4636	4559	4666	4559
q2	q3	3883	4424	3850	3850
q4	924	1211	797	797
q5	4121	4392	4317	4317
q6	183	178	139	139
q7	1789	1654	1526	1526
q8	2502	2760	2570	2570
q9	7668	7295	7475	7295
q10	3759	3995	3607	3607
q11	505	555	454	454
q12	512	602	467	467
q13	2759	3166	2409	2409
q14	282	305	284	284
q15	q16	747	762	724	724
q17	1172	1376	1375	1375
q18	7326	6933	6833	6833
q19	912	891	923	891
q20	2111	2142	1986	1986
q21	4033	3580	3307	3307
q22	471	433	367	367
Total cold run time: 50295 ms
Total hot run time: 47757 ms

doris-robot · 2026-03-16T09:10:07Z

TPC-DS: Total hot run time: 168007 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c4c0070b8e6e9a47d2e5fae6f20d4ff0f5d720d9, data reload: false

query5	4350	641	517	517
query6	320	221	198	198
query7	4223	500	270	270
query8	348	245	224	224
query9	8733	2791	2785	2785
query10	541	406	325	325
query11	6989	5078	4903	4903
query12	186	131	125	125
query13	1272	452	351	351
query14	5675	3679	3525	3525
query14_1	2876	2823	2831	2823
query15	205	195	179	179
query16	975	462	454	454
query17	1118	733	625	625
query18	2450	446	351	351
query19	223	203	182	182
query20	137	133	134	133
query21	219	132	112	112
query22	13413	13304	13184	13184
query23	15870	15566	15837	15566
query23_1	15970	15897	15995	15897
query24	7252	1694	1322	1322
query24_1	1283	1275	1324	1275
query25	553	516	433	433
query26	976	285	164	164
query27	3454	517	318	318
query28	4822	1970	1941	1941
query29	792	563	473	473
query30	298	216	188	188
query31	1006	933	870	870
query32	85	70	70	70
query33	522	344	273	273
query34	879	858	532	532
query35	643	668	619	619
query36	1065	1117	922	922
query37	136	97	81	81
query38	2989	2846	2896	2846
query39	857	841	815	815
query39_1	795	796	787	787
query40	252	151	133	133
query41	64	57	63	57
query42	256	255	261	255
query43	252	267	225	225
query44	
query45	194	186	183	183
query46	873	989	602	602
query47	2591	2100	2072	2072
query48	311	311	227	227
query49	622	457	380	380
query50	682	279	211	211
query51	4106	4095	3969	3969
query52	265	265	256	256
query53	286	334	283	283
query54	300	270	271	270
query55	89	87	88	87
query56	314	321	309	309
query57	1917	1785	1810	1785
query58	280	282	273	273
query59	2791	2939	2720	2720
query60	337	344	324	324
query61	147	146	150	146
query62	636	588	546	546
query63	306	276	282	276
query64	4467	1250	987	987
query65	
query66	1407	461	362	362
query67	24231	24202	24208	24202
query68	
query69	409	308	288	288
query70	964	971	923	923
query71	340	312	296	296
query72	2798	2830	2458	2458
query73	541	551	322	322
query74	9612	9551	9351	9351
query75	2846	2725	2477	2477
query76	2272	1033	691	691
query77	376	387	316	316
query78	11005	11136	10456	10456
query79	1085	820	572	572
query80	1293	630	544	544
query81	543	260	225	225
query82	1024	147	113	113
query83	332	266	248	248
query84	251	116	98	98
query85	882	478	432	432
query86	415	340	307	307
query87	3194	3118	3018	3018
query88	3552	2680	2661	2661
query89	441	368	343	343
query90	2023	198	181	181
query91	167	166	137	137
query92	80	75	76	75
query93	943	843	502	502
query94	640	325	283	283
query95	598	404	328	328
query96	631	524	235	235
query97	2464	2504	2396	2396
query98	232	227	234	227
query99	973	985	930	930
Total cold run time: 249994 ms
Total hot run time: 168007 ms

iaorekhov-1980 · 2026-03-16T11:52:23Z

Hello, @morningman
Please take a look for refreshed PR
I've tried "run buildall" once again, but "check_coverage_fe" still fails - as for many other builds from other contributors as well :(

iaorekhov-1980 changed the title ~~Fix/ldaps support~~ [enha]/auth introduction of ldaps support via configuration property Jan 27, 2026

iaorekhov-1980 marked this pull request as draft January 27, 2026 09:18

iaorekhov-1980 force-pushed the fix/ldaps_support branch from e6954e3 to 59a60c2 Compare January 27, 2026 09:20

iaorekhov-1980 marked this pull request as ready for review January 27, 2026 09:20

iaorekhov-1980 force-pushed the fix/ldaps_support branch from 2dc20f8 to 2cc92da Compare January 27, 2026 11:15

iaorekhov-1980 force-pushed the fix/ldaps_support branch from 4452270 to c73cc70 Compare January 27, 2026 13:44

github-actions bot added the reviewed label Mar 12, 2026

morningman approved these changes Mar 12, 2026

View reviewed changes

iaorekhov-1980 and others added 12 commits March 13, 2026 10:27

feat: add LDAPS support with configurable SSL/TLS connection

07fc9a4

added test for secure / insecure protocol

e8a3be4

fix: refactoring for url construction function

4e3957c

fix: missing import for code

2d19a13

fix: improve test logic for LDAP connection string

ae3f639

fix: refactoring getURL method to static one to enable unit testing

5971f63

fix: total refactoring of getConnectionURL method to support unit tes…

22430a0

…ting

fix: extra space

d3198cd

fix: indentation

dcaede1

fix: provide improved description for conf/ldap.conf

52780d2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: fixing javadoc for LdapConfig.java

4896cd5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: increased test quality by improving setUp method

c4c0070

iaorekhov-1980 force-pushed the fix/ldaps_support branch from 89ad517 to c4c0070 Compare March 13, 2026 07:53

Conversation

iaorekhov-1980 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

hello-stephen commented Jan 27, 2026

FE UT Coverage Report

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

doris-robot commented Jan 27, 2026

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

iaorekhov-1980 commented Jan 27, 2026

Uh oh!

hello-stephen commented Jan 27, 2026

FE Regression Coverage Report

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

morningman commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 12, 2026

Code Review Summary

Overall Assessment

Review Checklist

Observations (Non-blocking)

Uh oh!

morningman left a comment

Choose a reason for hiding this comment

Uh oh!

morningman commented Mar 13, 2026

Uh oh!

iaorekhov-1980 commented Mar 13, 2026

Uh oh!

iaorekhov-1980 commented Mar 13, 2026

iaorekhov-1980 commented Jan 27, 2026 •

edited

Loading

iaorekhov-1980 commented Mar 13, 2026 •

edited

Loading