Skip to content

[opt](in list) remove redundant condition in camp_field#60912

Open
zhangstar333 wants to merge 1 commit intoapache:masterfrom
zhangstar333:in_predicate
Open

[opt](in list) remove redundant condition in camp_field#60912
zhangstar333 wants to merge 1 commit intoapache:masterfrom
zhangstar333:in_predicate

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Feb 28, 2026

What problem does this PR solve?

Problem Summary:

in camp_field function, this or condition is same, (A && B) or (B and A)

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 28840 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 33645724b8d28d03ada64635fb205aedfb95d854, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17628	4514	4301	4301
q2	q3	10645	830	535	535
q4	4684	345	256	256
q5	7625	1183	1028	1028
q6	180	177	149	149
q7	803	831	658	658
q8	10000	1474	1343	1343
q9	5370	4743	4766	4743
q10	6858	1892	1636	1636
q11	457	266	254	254
q12	762	571	467	467
q13	17765	4228	3435	3435
q14	243	225	221	221
q15	958	818	787	787
q16	771	716	662	662
q17	708	888	402	402
q18	5948	5352	5308	5308
q19	1500	974	625	625
q20	500	483	388	388
q21	4590	1842	1395	1395
q22	343	285	247	247
Total cold run time: 98338 ms
Total hot run time: 28840 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4526	4374	4375	4374
q2	q3	1753	2175	1712	1712
q4	835	1164	765	765
q5	4028	4310	4331	4310
q6	182	172	140	140
q7	1713	1618	1492	1492
q8	2419	2657	2522	2522
q9	7618	7492	7441	7441
q10	2623	2855	2414	2414
q11	518	440	429	429
q12	496	596	462	462
q13	3958	4590	3655	3655
q14	284	301	282	282
q15	849	815	823	815
q16	743	776	743	743
q17	1213	1526	1278	1278
q18	7019	6687	6576	6576
q19	874	866	866	866
q20	2117	2169	1994	1994
q21	4115	3456	3369	3369
q22	480	438	386	386
Total cold run time: 48363 ms
Total hot run time: 46025 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183707 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 33645724b8d28d03ada64635fb205aedfb95d854, data reload: false

query5	5035	648	518	518
query6	323	214	198	198
query7	4203	462	273	273
query8	363	234	228	228
query9	8711	2735	2711	2711
query10	554	378	331	331
query11	16957	17372	17125	17125
query12	198	136	123	123
query13	1535	487	373	373
query14	6694	3612	3069	3069
query14_1	2996	2924	2891	2891
query15	235	209	186	186
query16	1005	478	455	455
query17	1600	735	602	602
query18	3036	471	360	360
query19	203	229	195	195
query20	136	132	127	127
query21	215	147	125	125
query22	5589	5066	4808	4808
query23	17150	16793	16552	16552
query23_1	16554	16777	16687	16687
query24	7184	1606	1224	1224
query24_1	1219	1228	1233	1228
query25	544	458	400	400
query26	1239	254	150	150
query27	2780	469	284	284
query28	4477	1848	1870	1848
query29	797	590	460	460
query30	315	242	207	207
query31	871	714	650	650
query32	78	69	66	66
query33	517	332	271	271
query34	922	900	558	558
query35	625	671	581	581
query36	1091	1129	1019	1019
query37	143	98	81	81
query38	2967	2900	2919	2900
query39	889	859	858	858
query39_1	830	845	839	839
query40	227	152	129	129
query41	62	60	58	58
query42	105	99	102	99
query43	368	373	346	346
query44	
query45	200	187	182	182
query46	880	989	609	609
query47	2090	2124	2071	2071
query48	312	312	233	233
query49	627	472	397	397
query50	674	285	217	217
query51	4180	4119	4036	4036
query52	105	105	94	94
query53	294	332	275	275
query54	288	261	249	249
query55	86	84	79	79
query56	313	298	298	298
query57	1396	1348	1283	1283
query58	279	293	265	265
query59	2570	2657	2494	2494
query60	336	331	320	320
query61	142	142	142	142
query62	618	583	549	549
query63	318	279	269	269
query64	4838	1282	984	984
query65	
query66	1376	445	335	335
query67	16198	16392	16467	16392
query68	
query69	408	300	282	282
query70	982	1001	961	961
query71	337	307	297	297
query72	2677	2706	2554	2554
query73	532	546	332	332
query74	9968	9916	9807	9807
query75	2869	2790	2478	2478
query76	2305	1041	694	694
query77	372	382	322	322
query78	11176	11317	10686	10686
query79	2399	800	600	600
query80	1774	639	573	573
query81	571	285	250	250
query82	1013	153	120	120
query83	338	265	253	253
query84	257	121	101	101
query85	958	583	430	430
query86	408	321	283	283
query87	3145	3114	3029	3029
query88	3549	2655	2640	2640
query89	420	375	347	347
query90	1989	170	172	170
query91	162	150	132	132
query92	74	74	66	66
query93	1008	864	497	497
query94	634	306	289	289
query95	573	397	314	314
query96	657	511	233	233
query97	2454	2544	2391	2391
query98	228	217	216	216
query99	1023	1004	898	898
Total cold run time: 256317 ms
Total hot run time: 183707 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 83.33% (10/12) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.57% (19629/37337)
Line Coverage 36.19% (183240/506358)
Region Coverage 32.48% (142137/437570)
Branch Coverage 33.45% (61669/184360)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 83.33% (10/12) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.55% (26157/36559)
Line Coverage 54.32% (274219/504805)
Region Coverage 51.68% (228281/441707)
Branch Coverage 53.00% (98003/184924)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants