Skip to content

[fix](float) fix float/double to string rouding causing inaccurate value#63096

Open
jacktengg wants to merge 1 commit into
apache:masterfrom
jacktengg:wt-260508-fix-float-to-str
Open

[fix](float) fix float/double to string rouding causing inaccurate value#63096
jacktengg wants to merge 1 commit into
apache:masterfrom
jacktengg:wt-260508-fix-float-to-str

Conversation

@jacktengg
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@jacktengg
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

  • regression-test/data/datatype_p0/nested_types/query/test_nested_types_insert_into_with_s3.out
  • regression-test/data/external_table_p0/hive/test_hive_basic_type.out

Consider using git-lfs to manage large files.

@github-actions github-actions Bot added the lfs-detected! Warning Label for use when LFS is detected in the commits of a Pull Request label May 9, 2026
@jacktengg
Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

TPC-H: Total hot run time: 29756 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d1eb3ea20c211fd77cdadc590f293a066a2e4ad2, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17691	3916	3866	3866
q2	q3	10721	914	620	620
q4	4693	467	353	353
q5	7760	1335	1158	1158
q6	259	169	141	141
q7	932	938	782	782
q8	10222	1404	1327	1327
q9	6578	5370	5321	5321
q10	6342	2103	1835	1835
q11	482	265	257	257
q12	691	430	296	296
q13	18160	3313	2788	2788
q14	293	281	261	261
q15	q16	911	862	793	793
q17	1016	1056	746	746
q18	6493	5746	5485	5485
q19	1601	1265	1139	1139
q20	575	509	298	298
q21	4903	2363	1953	1953
q22	482	398	337	337
Total cold run time: 100805 ms
Total hot run time: 29756 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4721	4538	4649	4538
q2	q3	4706	4786	4263	4263
q4	2274	2205	1434	1434
q5	5008	5053	5283	5053
q6	200	172	131	131
q7	2054	1874	1613	1613
q8	3384	3164	3217	3164
q9	8650	8487	8411	8411
q10	4484	4563	4259	4259
q11	650	410	410	410
q12	699	751	525	525
q13	3348	3516	2924	2924
q14	296	310	268	268
q15	q16	802	780	692	692
q17	1347	1322	1279	1279
q18	8068	7188	7047	7047
q19	1181	1131	1168	1131
q20	2274	2253	1966	1966
q21	6258	5443	4841	4841
q22	524	484	407	407
Total cold run time: 60928 ms
Total hot run time: 54356 ms

@hello-stephen
Copy link
Copy Markdown
Contributor

TPC-DS: Total hot run time: 171880 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d1eb3ea20c211fd77cdadc590f293a066a2e4ad2, data reload: false

query5	4328	656	511	511
query6	342	222	209	209
query7	4233	562	298	298
query8	322	234	222	222
query9	8835	4075	4109	4075
query10	456	348	300	300
query11	5798	2417	2236	2236
query12	177	129	128	128
query13	1297	594	445	445
query14	6694	5353	5103	5103
query14_1	4320	4311	4302	4302
query15	217	202	185	185
query16	1027	500	470	470
query17	1139	740	621	621
query18	2666	482	360	360
query19	218	204	160	160
query20	138	130	134	130
query21	221	139	117	117
query22	13702	13617	13410	13410
query23	17355	16480	16108	16108
query23_1	16159	16204	16266	16204
query24	7439	1750	1373	1373
query24_1	1351	1349	1366	1349
query25	577	503	449	449
query26	1306	323	170	170
query27	2707	580	372	372
query28	4453	1987	1955	1955
query29	1064	643	510	510
query30	302	243	199	199
query31	1153	1065	946	946
query32	88	75	74	74
query33	534	350	288	288
query34	1167	1173	626	626
query35	807	797	666	666
query36	1380	1361	1232	1232
query37	150	101	91	91
query38	3238	3132	3103	3103
query39	938	936	907	907
query39_1	884	874	859	859
query40	232	162	135	135
query41	65	61	63	61
query42	114	112	110	110
query43	324	331	286	286
query44	
query45	210	199	194	194
query46	1054	1190	741	741
query47	2337	2310	2189	2189
query48	401	401	288	288
query49	637	537	429	429
query50	715	287	218	218
query51	4345	4304	4267	4267
query52	106	106	96	96
query53	256	279	206	206
query54	311	265	250	250
query55	98	89	85	85
query56	294	297	310	297
query57	1416	1387	1298	1298
query58	298	282	259	259
query59	1592	1644	1439	1439
query60	339	344	337	337
query61	161	174	176	174
query62	671	653	560	560
query63	248	208	212	208
query64	2451	874	720	720
query65	
query66	1728	538	416	416
query67	30300	29316	29228	29228
query68	
query69	489	386	327	327
query70	1071	997	965	965
query71	325	283	274	274
query72	3117	2956	2455	2455
query73	840	742	445	445
query74	5081	4909	4739	4739
query75	2795	2641	2327	2327
query76	2322	1119	767	767
query77	441	425	342	342
query78	12971	12995	12454	12454
query79	1513	969	750	750
query80	1360	576	474	474
query81	525	276	242	242
query82	971	163	122	122
query83	320	275	250	250
query84	266	140	109	109
query85	908	500	435	435
query86	466	321	328	321
query87	3429	3350	3200	3200
query88	3547	2666	2674	2666
query89	445	377	345	345
query90	1902	184	179	179
query91	214	164	141	141
query92	77	79	77	77
query93	1257	956	560	560
query94	700	340	300	300
query95	682	464	351	351
query96	1084	771	322	322
query97	2730	2694	2627	2627
query98	240	243	234	234
query99	1086	1138	975	975
Total cold run time: 255579 ms
Total hot run time: 171880 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lfs-detected! Warning Label for use when LFS is detected in the commits of a Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants