Skip to content

[refine](core) add compile-time safety checks to assert_cast #63133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mryange merged 1 commit into from
May 12, 2026
+8 −0
Merged

[refine](core) add compile-time safety checks to assert_cast #63133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions be/src/core/assert_cast.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ struct AssertCastNormalizedType {
template <typename T>
using AssertCastNormalizedType_t = typename AssertCastNormalizedType<T>::type;

template <typename T>
using AssertCastClassType_t = std::remove_pointer_t<AssertCastNormalizedType_t<T>>;

/** Perform static_cast in release build when TypeCheckOnRelease is set to DISABLE.
* Checks type by comparing typeid and throw an exception in all the other situations.
* The exact match of the type is checked. That is, cast to the ancestor will be unsuccessful.
Expand All @@ -50,6 +53,11 @@ template <typename To, TypeCheckOnRelease check = TypeCheckOnRelease::ENABLE, ty
PURE To assert_cast(From&& from) {
static_assert(!std::is_same_v<AssertCastNormalizedType_t<To>, AssertCastNormalizedType_t<From>>,
"assert_cast is redundant for the same type after removing cv/ref qualifiers");
static_assert(std::is_class_v<AssertCastClassType_t<To>> &&
std::is_class_v<AssertCastClassType_t<From>>,
"assert_cast requires casting between class pointer/reference types");
static_assert(std::is_base_of_v<AssertCastClassType_t<From>, AssertCastClassType_t<To>>,
"assert_cast only supports downcast from a base type to a derived type");

// https://godbolt.org/z/nrsx7nYhs
// perform_cast will not be compiled to asm in release build with TypeCheckOnRelease::DISABLE
Expand Down
Loading