feat: web console: add file uri tooltip to sample data view - #19741
Conversation
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 0 |
| Total | 1 |
Reviewed 4 of 4 changed files.
This is an automated review by Codex GPT-5.6-Sol
|
|
||
| const addFileUri = Boolean( | ||
| ioConfig.inputSource && | ||
| getPossibleSystemFieldsForInputSource(ioConfig.inputSource).includes('__file_uri'), |
There was a problem hiding this comment.
[P2] Include HTTP sources in the file-URI gate
getPossibleSystemFieldsForInputSource returns no fields for http, even though HttpInputSource supports both __file_uri and __file_path. As a result this new gate never requests __file_uri for HTTP samples, so the tooltip is absent for the web console's common URL-based sample flow. Add HTTP to the supported-source mapping and cover the generated sampler request.
There was a problem hiding this comment.
Great spot! fixed
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
Confirmed that the follow-up adds http to getPossibleSystemFieldsForInputSource, so sampleForConnect now requests and surfaces __file_uri for HTTP sources. The original issue is resolved.
Reviewed 8 of 8 changed files.
This is an automated review by Codex GPT-5.6-Sol
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
I reviewed the update and full PR for correctness, edge cases, UI states, and integration risks; no new issues were found.
Reviewed 13 of 13 changed files.
This is an automated review by Codex GPT-5.6-Sol
3 participants
query the __file_uri system field if it is possible for the input source and show it in a tooltip